From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH REGENERATED] ahci: reimplement port_map handling
Date: Thu, 20 Sep 2007 17:25:01 -0400 [thread overview]
Message-ID: <46F2E52D.4030103@garzik.org> (raw)
In-Reply-To: <20070903034457.GE16890@htj.dyndns.org>
Tejun Heo wrote:
> Reimplement port_map handling such that
>
> 1. Non-zero PORTS_IMPL value is always examined and used if consistent
> with cap.n_ports.
>
> 2. When PI and cat.n_ports are inconsistent, honor cap.n_ports and
> force port_map to be ((1 << cap.n_ports) - 1).
>
> 3. There were two separate places dealing with port_map. Unify them
> to one.
>
> As all newer ahci chips seem to get PI correct and older ones usually
> have zero PI. Controllers with holes in PI are very unlikely to screw
> up PI, so #2 makes more sense than following inconsistent PI.
>
> Without this change, not setting ATA_FLAG_HONOR_PI when it's needed
> results in weird detection failure. This changed logic should be able
> to handle all known cases correctly automatically.
>
> Verified on ICH6 (reports 0 PI), ICH8 (with holes in port_map), ICH9,
> JMB360 and JMB363.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> Regenerated on top of the current #upstream.
applied... let's see what explodes :)
prev parent reply other threads:[~2007-09-20 21:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-20 8:59 [PATCH] ahci: reimplement port_map handling Tejun Heo
2007-07-20 9:10 ` Tejun Heo
2007-07-20 12:08 ` Jeff Garzik
2007-07-20 12:19 ` Tejun Heo
2007-09-03 3:44 ` [PATCH REGENERATED] " Tejun Heo
2007-09-20 21:25 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F2E52D.4030103@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.