From: Jeff Garzik <jgarzik@pobox.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: linux-ide <linux-ide@vger.kernel.org>,
linux acpi <linux-acpi@vger.kernel.org>,
Len Brown <lenb@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH]libata-acpi: add ACPI _PSx method
Date: Thu, 20 Sep 2007 18:00:17 -0400 [thread overview]
Message-ID: <46F2ED71.3070603@pobox.com> (raw)
In-Reply-To: <1189737938.6330.7.camel@sli10-conroe.sh.intel.com>
Shaohua Li wrote:
> ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx
> methods. As recently most PATA drivers use libata, this patch adds _PSx
> method support in libata. ACPI spec doesn't mention if SATA requires the
> same _PSx method, but executing _PSx for SATA should be ok I think.
>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
ahci and sata_sil24 directly power off components, so it seems quite
unwise for "modern" SATA controllers.
ISTR Tejun, when he cleaned up libata-acpi, finally figured out a good
way to distinguish ACPI's idea of "IDE" -- which sometimes includes the
legacy programming mode of SATA controllers, and a controller running a
modern programming mode.
Your best bet is to use a similar test when deciding when to execute
_PSx. Or, you could simply be conservative and only do it for PATA.
outside of those issues, the rest of the patch looks ok.
next prev parent reply other threads:[~2007-09-20 22:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 2:45 [PATCH]libata-acpi: add ACPI _PSx method Shaohua Li
2007-09-14 3:21 ` Jeff Garzik
2007-09-14 3:11 ` Shaohua Li
2007-09-20 22:00 ` Jeff Garzik [this message]
2007-09-21 1:16 ` Shaohua Li
2007-09-21 2:20 ` Tejun Heo
2007-09-21 2:17 ` Shaohua Li
2007-10-31 2:27 ` Len Brown
2007-10-31 13:26 ` Rafael J. Wysocki
2007-11-01 2:50 ` Shaohua Li
2007-11-01 10:04 ` Alan Cox
2007-11-02 1:32 ` Shaohua Li
2007-11-02 11:16 ` Rafael J. Wysocki
2007-11-05 1:26 ` Shaohua Li
2007-11-03 13:00 ` Jeff Garzik
2007-11-05 1:12 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F2ED71.3070603@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@linux-foundation.org \
--cc=htejun@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.