From: Tejun Heo <htejun@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jeff@garzik.org>,
linux-ide@vger.kernel.org, desaster.area@addcom.de,
alan@redhat.com, bzolnier@gmail.com
Subject: Re: [PATCH] pata_sis: add missing UDMA5 timing value in sis_66_set_dmamode()
Date: Fri, 21 Sep 2007 19:38:43 +0900 [thread overview]
Message-ID: <46F39F33.1030501@gmail.com> (raw)
In-Reply-To: <20070921114148.45c90b62@the-village.bc.nu>
Alan Cox wrote:
> On Fri, 21 Sep 2007 16:29:05 +0900
> Tejun Heo <htejun@gmail.com> wrote:
>
>> sis_66_set_dmamode() also handles early UDMA100 (SIS630 ET) but is
>> missing udma timing value for UDMA100. According to sis5513, this
>> should be 0x8000. This caused UDMA100 device to fail on pata_sis till
>> it downgrades to UDMA66 while it works fine on sis5513 at UDMA100.
>>
>> Reported by Adam Blech.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
>> Cc: Adam Blech <desaster.area@addcom.de>
>
> Acked-by: Alan Cox <alan@redhat.com>
>
> I was just looking at this as we had a Red Hat bug for it 8)
>
I caught this one from a SUSE bug. I guess distros are useful from time
to time. :-)
--
tejun
next prev parent reply other threads:[~2007-09-21 10:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 7:29 [PATCH] pata_sis: add missing UDMA5 timing value in sis_66_set_dmamode() Tejun Heo
2007-09-21 10:41 ` Alan Cox
2007-09-21 10:38 ` Tejun Heo [this message]
2007-09-25 22:06 ` Chuck Ebbert
2007-09-26 1:39 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F39F33.1030501@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alan@redhat.com \
--cc=bzolnier@gmail.com \
--cc=desaster.area@addcom.de \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.