From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: slightly improved req-sense, send-diag no-ops
Date: Fri, 21 Sep 2007 07:12:59 -0400 [thread overview]
Message-ID: <46F3A73B.9040309@garzik.org> (raw)
In-Reply-To: <20070921121717.16c7dcf1@the-village.bc.nu>
Alan Cox wrote:
>> REQUEST SENSE -- as we autosense, R.S. just returns zeroes
>>
>> SEND DIAGNOSTIC -- our default (no-op) self-test succeeds, all
>> other requests for testing fail.
>>
>> Signed-off-by: Jeff Garzik <jeff@garzik.org>
>
> Acked-by: Alan Cox <alan@redhat.com>
>
> Possibly our default SEND_DIAGNOSTIC should turn into smart or just
> return whether the drive failed the power up diagnostic ?
Either/or. In general the SAT (SCSI/ATA translation) spec posted
publicly on http://www.t10.org/ gives the suggested transformation into
ATA commands. And yep, you guessed it -- send diag morphs into SMART.
I doubt I'm motivated enough to enhance send diag, but others are
encouraged to do so.
Jeff
prev parent reply other threads:[~2007-09-21 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 10:24 [PATCH] libata: slightly improved req-sense, send-diag no-ops Jeff Garzik
2007-09-21 11:17 ` Alan Cox
2007-09-21 11:12 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F3A73B.9040309@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.