From: Slava Abramov <slava.abramov@amd.com>
To: linux-kernel@vger.kernel.org
Subject: ptep_test_and_clear_young() i386 vs. x86_64
Date: Fri, 21 Sep 2007 15:14:52 -0400 [thread overview]
Message-ID: <46F4182C.9050202@amd.com> (raw)
Hi All!
Is there any special reason why ptep_test_and_clear_young()
implementation for x86_64 does not call pte_update()?
Compare the following:
include/asm-x86_64/pgtable.h:
static inline int ptep_test_and_clear_young(struct vm_area_struct *vma,
unsigned long addr, pte_t *ptep)
{
if (!pte_young(*ptep))
return 0;
return test_and_clear_bit(_PAGE_BIT_ACCESSED, &ptep->pte);
}
include/asm-i386/pgtable.h:
#define ptep_test_and_clear_young(vma, addr, ptep) ({ \
int __ret = 0; \
if (pte_young(*(ptep))) \
__ret = test_and_clear_bit(_PAGE_BIT_ACCESSED, \
&(ptep)->pte_low); \
if (__ret) \
pte_update((vma)->vm_mm, addr, ptep);
\
__ret; \
})
Slava
next reply other threads:[~2007-09-21 19:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 19:14 Slava Abramov [this message]
2007-09-21 19:42 ` ptep_test_and_clear_young() i386 vs. x86_64 Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F4182C.9050202@amd.com \
--to=slava.abramov@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.