All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2] libata: translate INQUIRY VPD page 89h (ATA info)
Date: Fri, 21 Sep 2007 21:05:40 -0400	[thread overview]
Message-ID: <46F46A64.40707@garzik.org> (raw)
In-Reply-To: <20070922005444.GA29744@havoc.gtf.org>

Jeff Garzik wrote:
> +	memcpy(&pbuf[8], "ATA     ", 8);
> +	ata_id_string(args->id, &pbuf[16], ATA_ID_PROD, 16);
> +	ata_id_string(args->id, &pbuf[32], ATA_ID_FW_REV, 4);


And I just checked in a fix that changes the above to reflect the SCSI 
simulator's vendor/product/version (linux/libata/DRV_VERSION), rather 
than the ATA device's, as the spec wants.

	Jeff



      reply	other threads:[~2007-09-22  1:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-21  9:48 [PATCH] libata: translate INQUIRY VPD page 89h (ATA info) Jeff Garzik
2007-09-21 14:12 ` James Bottomley
2007-09-21 20:05   ` Jeff Garzik
2007-09-21 23:25   ` Jeff Garzik
2007-09-22  0:54 ` [PATCH v2] " Jeff Garzik
2007-09-22  1:05   ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46F46A64.40707@garzik.org \
    --to=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.