Re: [PATCH] New Aztech Sound Galaxy driver

[Rene Herman <rene.herman@gmail.com>]

On 09/20/2007 02:51 PM, Takashi Iwai wrote:

> At Thu, 20 Sep 2007 14:20:01 +0200,
> Rene Herman wrote:

>> lib.c was split off in preparation of having snd-azt2320 use it as well
>> and generally containing non soundgalaxy specific code that might at
>> some point make it into an isa/lib.c or something. It's tiny, so it's
>> not constructed as a helper module but simply compiled into both
>> drivers.
> 
> This doesn't work if both modules can be loaded at the same time in 
> theory.  You'll get symbol crashes.  To avoid this, make all functions 
> static and include from both, or make it a library module.

Hrmmpf. Yes.

>> Given that they are new drivers with new names, they shouldn't disturb
>> anything and can as far as I'm concerned make 1.0.15 but if you feel
>> it's too late (and/or don't want the two seperate drivers), so be it. I
>> can also submit a next patch removing the old sgalaxy driver now or
>> just wait with that one...
> 
> Well, I feel we can work better on this after 1.0.15.  RC standas for 
> release-candiate, after all :)

Sure. With new drivers, you can sort of by definition not be introducing 
regressions (well, other than of the type above, that is...) but oh well, 
hardly any magic to 1.0.15. I'll check what my older I38-MMSN803 needs and 
get that one in as well then and also redo azt2320 using some common code.

I have a question about that by the way: ALSA ISA-PnP drivers today allow to 
manually set resource values through specifying them as module parameters 
and I've always really disliked that as a rather major layering violation.

With respect to the high-level interface, ISA-PnP isn't all that different 
from PCI and as with PCI the expected use is not specifying parameters and 
just having the system pick/tell you which resources it's using. Now with 
ISA-PnP you _can_ actually change them but I very much believe that in the 
few odd cases where someone might actually want to do that, it should be 
done not in soundcard drivers but at the correct layer (the PnP layer allows 
to echo values into sysfs for this). Especially in mixed legacy/pnp drivers, 
I feel that the current setup is mostly just confusing and as said, a 
layering violation.

As such -- would you terribly mind if I not put in the pnp_resource_change() 
stuff in rewritten and/or cleaned up ISA-PnP drivers?

Rene.