From: Michal Vitecek <fuf@mageo.cz>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] Use "" instead of "<unknown>" for placeholders
Date: Sat, 22 Sep 2007 10:53:41 +0200 [thread overview]
Message-ID: <46F4D815.5050602@mageo.cz> (raw)
In-Reply-To: <7vk5qjixqy.fsf@gitster.siamese.dyndns.org>
Junio C Hamano wrote:
>>>>>> I made it because I want to use my own pretty format which currently
>>>>>> only allows '%s' for subject and '%b' for body. But '%b' is
>>>>>> substituted with <undefined> if the body is "missing" which I
>>>>>> obviously don't like :)
>>>>> Then you should fix %b not to show "<undefined>".
>>>> I'll do it if it is okay. Shall I do the same for the other
>>>> placeholders as well?
>>> Yeah. Don't know why I did it that way.
>> Here comes the big patch :)
>
> Now, this breaks t6006 which needs this patch.
Oops - I'm sorry about that. I ran the test suite (1.5.3.1) but it
failed in 2 tests before the patch and in 2 tests after it so I
considered it okay.
> Looking at this patch, I am not sure if your change is really a
> desirable one --- shouldn't it be removing the line itself, not
> just <unknown> token?
This sounds as the best solution. I'll look into it. Thanks for your time.
--
fuf (fuf@mageo.cz)
next prev parent reply other threads:[~2007-09-22 8:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-21 10:14 [PATCH] Added a new placeholder '%cm' for full commit message Michal Vitecek
2007-09-21 10:47 ` Johannes Schindelin
2007-09-21 11:06 ` Michal Vitecek
2007-09-21 11:08 ` Johannes Schindelin
2007-09-21 14:05 ` [PATCH] Use "" instead of "<unknown>" for placeholders [was Re: [PATCH] Added a new placeholder '%cm' for full commit message] Michal Vitecek
2007-09-21 20:12 ` [PATCH] Use "" instead of "<unknown>" for placeholders Junio C Hamano
2007-09-21 20:41 ` Johannes Schindelin
2007-09-22 8:53 ` Michal Vitecek [this message]
2007-09-25 9:43 ` Michal Vitecek
2007-09-25 10:25 ` Johannes Schindelin
2007-09-25 10:52 ` Michal Vitecek
2007-09-25 12:46 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F4D815.5050602@mageo.cz \
--to=fuf@mageo.cz \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.