Re: [Adeos-main] [PATCH] fix irq statistics

[Jan Kiszka <jan.kiszka@domain.hid>]

[-- Attachment #1: Type: text/plain, Size: 999 bytes --]

Philippe Gerum wrote:
> On Wed, 2007-09-19 at 10:51 +0200, Jan Kiszka wrote:
>> Hi,
>>
>> IRQ hit counters are broken in latest I-pipe 1.10-x for the wired path. 
>> This patch moves the counter maintenance out of __ipipe_set_irq_pending 
>> and instead makes it explicit at the required spots.
> 
> I would rather add the missing accounting code as below. Marking an
> interrupt as pending using the __ipipe_set_irq_pending() interface
> should implicitely be paired with proper accounting.

My original intention was to keep __ipipe_dispatch_wired compact.

But thinking about this again, I wonder if the whole thing makes sense
as it is implemented right now: Given that I-pipe users like Xenomai now
use this irqall counter as high-level hit counter, I'm not that sure we
should also account for IRQ events on locked lines or in case of stalled
receiver domains. Only _delivery_, ie. handler invocation, should be
counted IMO (=>__ipipe_run_isr). What do you think?

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]