From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IZXzw-0005qA-GJ
	for qemu-devel@nongnu.org; Sun, 23 Sep 2007 16:24:12 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IZXzu-0005py-Uc
	for qemu-devel@nongnu.org; Sun, 23 Sep 2007 16:24:11 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IZXzu-0005pv-OK
	for qemu-devel@nongnu.org; Sun, 23 Sep 2007 16:24:10 -0400
Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <gceq-qemu-devel@m.gmane.org>)
	id 1IZXzu-0006PX-AC
	for qemu-devel@nongnu.org; Sun, 23 Sep 2007 16:24:10 -0400
Received: from list by ciao.gmane.org with local (Exim 4.43)
	id 1IZXxU-0001Op-4y
	for qemu-devel@nongnu.org; Sun, 23 Sep 2007 20:21:40 +0000
Received: from d83-190-180-66.cust.tele2.it ([83.190.180.66])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Sun, 23 Sep 2007 20:21:40 +0000
Received: from lorenzo.campedelli by d83-190-180-66.cust.tele2.it with local
	(Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Sun, 23 Sep 2007 20:21:40 +0000
From: Lorenzo Campedelli <lorenzo.campedelli@tele2.it>
Date: Sun, 23 Sep 2007 22:17:42 +0200
Message-ID: <46F6C9E6.8080503@tele2.it>
References: <219e947f0709221443l494e4c46w6efafce989dbb867@mail.gmail.com>	<Pine.LNX.4.64.0709222342190.28395@racer.site>	<fd54o8$kjc$1@sea.gmane.org>	<Pine.LNX.4.64.0709231223040.28395@racer.site>	<46F68C56.8000408@tele2.it>
	<Pine.LNX.4.64.0709232017280.28395@racer.site>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <Pine.LNX.4.64.0709232017280.28395@racer.site>
Sender: news <news@sea.gmane.org>
Subject: [Qemu-devel] Re: [PATCH] vvfat mbr fixes
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Johannes Schindelin wrote:
> Hi,
> 
> On Sun, 23 Sep 2007, Lorenzo Campedelli wrote:
> 
>> I was concerned by having this handling outside of a proper place (i.e. 
>> block-vvfat.c), but if we want to leave it there, wouldn't it be better 
>> to just handle cases which would otherwise fail, and just try to fix the 
>> "fat:" format?
> 
> I don't like that option, since it special-cases vvfat to much.
> 
> Ciao,
> Dscho
> 
> 
> 
> 
I agree the fix is ugly, otoh the problem is also a special case...
I don't see a clean way of fixing this, the code in block.c needs to 
know how to handle a vvfat specific filename format.

I'll keep my "works for me" patch waiting for some better fix.

Thanks for your time.
Lorenzo