All of lore.kernel.org
 help / color / mirror / Atom feed
From: Farkas Levente <lfarkas-lWVWdrzSO4GHXe+LvDLADg@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [ANNOUNCE] kvm-44 release
Date: Mon, 24 Sep 2007 10:37:01 +0200	[thread overview]
Message-ID: <46F7772D.8010901@bppiac.hu> (raw)
In-Reply-To: <46F772D0.7050102-atKUWr5tajBWk0Htik3J/w@public.gmane.org>

Avi Kivity wrote:
> Farkas Levente wrote:
>> Avi Kivity wrote:
>>  
>>> Farkas Levente wrote:
>>>    
>>>> Avi Kivity wrote:
>>>>  
>>>>      
>>>>> An important fix to guest smp (it boots now!), and a performance
>>>>> improvement on Intel hardware.  I get about 5% boost on a kernel
>>>>> build.
>>>>>
>>>>> There's a new module parameter to kvm-intel.ko that can disable this
>>>>> mechanism, bypass_guest_pf.  Load the module with bypass_guest_pf=0
>>>>> to disable the optimization.  It shouldn't be necessary to do that on
>>>>> current processors; it's mostly to protect kvm against changes in
>>>>> hardware since the patch uses reserved bits.
>>>>>             
>>>> make[1]: Entering directory `/usr/src/kernels/2.6.18-8.1.10.el5-x86_64'
>>>>   LD    
>>>> /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/built-in.o
>>>>   CC [M]  /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/svm.o
>>>>   CC [M]  /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/vmx.o
>>>>   CC [M]
>>>> /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/vmx-debug.o
>>>>   CC [M]
>>>> /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/kvm_main.o
>>>>   CC [M]  /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/mmu.o
>>>> /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/mmu.c:1152:
>>>> error:
>>>> expected '=', ',', ';', 'asm' or '__attribute__' before
>>>> 'last_updated_pte_accessed'
>>>> /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/mmu.c: In
>>>> function
>>>> 'kvm_mmu_pte_write':
>>>> /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/mmu.c:1180:
>>>> error:
>>>> implicit declaration of function 'last_updated_pte_accessed'
>>>> make[2]: ***
>>>> [/home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/mmu.o] Error 1
>>>> make[1]: ***
>>>> [_module_/home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel] Error 2
>>>> make[1]: Leaving directory `/usr/src/kernels/2.6.18-8.1.10.el5-x86_64'
>>>> make: *** [all] Error 2
>>>>
>>>>         
>>> Try adding '#define bool _Bool' to kernel/external-module-compat.h, and
>>> let us know. I'll fix it for kvm-45.
>>>     
>>
>> i just put after the #include <linux/smp.h> but it doesn't help.
>>
>>   
> 
> That should have worked.  How about '#define bool int'?

with _Bool:
  CC [M]  /home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/vmx.o
/home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/vmx.c:39: error:
expected ')' before '&' token
/home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/vmx.c:39: error:
'param_set__Bool' undeclared here (not in a function)
/home/robot/rpm/BUILD/kvm-kmod-44/_kmod_build_/kernel/vmx.c:39: error:
'param_get__Bool' undeclared here (not in a function)
with int it's working

-- 
  Levente                               "Si vis pacem para bellum!"

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/

      parent reply	other threads:[~2007-09-24  8:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-23 14:25 [ANNOUNCE] kvm-44 release Avi Kivity
     [not found] ` <46F6775E.3010508-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-09-23 19:48   ` Farkas Levente
     [not found]     ` <46F6C2FA.7080303-lWVWdrzSO4GHXe+LvDLADg@public.gmane.org>
2007-09-24  7:43       ` Avi Kivity
     [not found]         ` <46F76AA1.1090200-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-09-24  8:05           ` Farkas Levente
     [not found]             ` <46F76FBA.1040907-lWVWdrzSO4GHXe+LvDLADg@public.gmane.org>
2007-09-24  8:18               ` Avi Kivity
     [not found]                 ` <46F772D0.7050102-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-09-24  8:37                   ` Farkas Levente [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46F7772D.8010901@bppiac.hu \
    --to=lfarkas-lwvwdrzso4ghxe+lvdladg@public.gmane.org \
    --cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.