From: Donald Douwsma <donaldd@sgi.com>
To: xfs-oss <xfs@oss.sgi.com>
Subject: Review: Fix xfsidbg.c compiler warnings on x86_64
Date: Mon, 24 Sep 2007 19:17:17 +1000 [thread overview]
Message-ID: <46F7809D.1040900@sgi.com> (raw)
Fix compile warnings for xfsidbg.c as seen on x86_64.
--- 2.6.x-xfs.orig/fs/xfs/xfsidbg.c
+++ 2.6.x-xfs/fs/xfs/xfsidbg.c
@@ -1798,10 +1798,10 @@ xfs_itrace_pr_entry(ktrace_entry_t *ktep
if ((__psint_t)ktep->val[0] == 0)
return 0;
- if (kdbnearsym((unsigned int)ktep->val[8], &symtab)) {
+ if (kdbnearsym((unsigned long)ktep->val[8], &symtab)) {
unsigned long offval;
- offval = (unsigned int)ktep->val[8] - symtab.sym_start;
+ offval = (unsigned long)ktep->val[8] - symtab.sym_start;
if (offval)
sprintf(funcname, "%s+0x%lx", symtab.sym_name, offval);
@@ -1871,13 +1871,13 @@ xfs_itrace_pr_entry(ktrace_entry_t *ktep
kdb_printf("\n");
- kdb_printf(" cpu = %ld pid = %d ",
- (long)ktep->val[6], (pid_t)ktep->val[7]);
+ kdb_printf(" cpu = %ld pid = %ld ",
+ (long)ktep->val[6], (long)ktep->val[7]);
- if (kdbnearsym((unsigned int)ktep->val[4], &symtab)) {
+ if (kdbnearsym((unsigned long)ktep->val[4], &symtab)) {
unsigned long offval;
- offval = (unsigned int)ktep->val[4] - symtab.sym_start;
+ offval = (unsigned long)ktep->val[4] - symtab.sym_start;
if (offval)
kdb_printf(" ra = %s+0x%lx", symtab.sym_name, offval);
next reply other threads:[~2007-09-24 9:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-24 9:17 Donald Douwsma [this message]
2007-09-24 18:03 ` Review: Fix xfsidbg.c compiler warnings on x86_64 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F7809D.1040900@sgi.com \
--to=donaldd@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.