All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 2.6.22.3 1/5] nfnetlink_log: Kill duplicate code
Date: Mon, 24 Sep 2007 14:26:49 +0200	[thread overview]
Message-ID: <46F7AD09.7040002@trash.net> (raw)
In-Reply-To: <20070921164826.GA3779@rere.qmqm.pl>

Micha³ Miros³aw wrote:
> Kill some cut'n'paste effect.
> Just after __nfulnl_send() returning, inst->skb is always NULL.


This patch introduces a warning:

net/netfilter/nfnetlink_log.c: In function '__nfulnl_flush':
net/netfilter/nfnetlink_log.c:365: warning: control reaches end of
non-void function

I fixed it by changing __nfulnl_flush to void, but please make sure
this doesn't happen again.

-
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2007-09-24 12:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-21 16:48 [PATCH 2.6.22.3 1/5] nfnetlink_log: Kill duplicate code Michał Mirosław
2007-09-24 12:26 ` Patrick McHardy [this message]
2007-09-24 15:42   ` Michał Mirosław

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46F7AD09.7040002@trash.net \
    --to=kaber@trash.net \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.