From: Andreas Ericsson <ae@op5.se>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: diffcore-rename performance mode
Date: Tue, 25 Sep 2007 21:10:06 +0200 [thread overview]
Message-ID: <46F95D0E.5090000@op5.se> (raw)
In-Reply-To: <20070925190640.GA4613@coredump.intra.peff.net>
Jeff King wrote:
> On Tue, Sep 25, 2007 at 12:38:43PM -0400, Jeff King wrote:
>
>> [...]
>>
>> What is most confusing is why the 'somefree' case performs so badly,
>> since we should just be using the cnt_data. I'll see if gprof can shed
>
> OK, I found the problem. estimate_similarity calls
> diff_populate_filespec each time, even if we already have the cnt_data,
> which leads to recomputing the blob contents from deltas. Oops.
>
> Fixing this, the correct numbers are:
>
> | stock | nofree | old somefree | fixed somefree
> -----------------|-----------------------------------------------
> user time (s) | 76.78 | 16.96 | 46.26 | 16.99
> peak memory (Kb) | 52300 | 66796 | 59156 | 57328
>
> So now we're at a 4.5x speedup for about 10% extra memory usage. Patch
> will follow.
>
Nice work :)
--
Andreas Ericsson andreas.ericsson@op5.se
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
next prev parent reply other threads:[~2007-09-25 19:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 8:23 diffcore-rename performance mode Jeff King
2007-09-18 8:49 ` Junio C Hamano
2007-09-18 8:54 ` Jeff King
2007-09-18 8:58 ` Junio C Hamano
2007-09-18 9:01 ` Jeff King
2007-09-18 9:17 ` Junio C Hamano
2007-09-18 11:20 ` Johannes Schindelin
2007-09-25 16:38 ` Jeff King
2007-09-25 19:06 ` Jeff King
2007-09-25 19:10 ` Andreas Ericsson [this message]
2007-09-25 19:32 ` David Kastrup
2007-09-25 19:52 ` Jeff King
2007-09-18 22:12 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46F95D0E.5090000@op5.se \
--to=ae@op5.se \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.