From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Emelyanov Subject: Re: [PATCH 1/5] Add notification about some major slab events Date: Wed, 26 Sep 2007 13:37:31 +0400 Message-ID: <46FA285B.5060709@openvz.org> References: <46F91841.9070708@openvz.org> <46F91898.5060400@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Christoph Lameter Cc: Linux Containers , Balbir Singh List-Id: containers.vger.kernel.org Christoph Lameter wrote: > On Tue, 25 Sep 2007, Pavel Emelyanov wrote: > >> @@ -28,6 +28,7 @@ >> #define SLAB_DESTROY_BY_RCU 0x00080000UL /* Defer freeing slabs to RCU */ >> #define SLAB_MEM_SPREAD 0x00100000UL /* Spread some memory over cpuset */ >> #define SLAB_TRACE 0x00200000UL /* Trace allocations and frees */ >> +#define SLAB_NOTIFY 0x00400000UL /* Notify major events */ >> > > You need to add SLAB_NOTIFY to the SLUB_NEVER_MERGE group. That way you > can solve the merging issue. True, but we mark the slubs as notifyable at runtime, after they are merged. However, once someone decides to make his slab notifyable from the very beginning this makes sense, thanks. > Otherwise this looks okay now. Oh, great! Does this mean I can put Acked-by when sending this to Andrew? Thanks, Pavel