All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@domain.hid>
To: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
Cc: Xenomai-core@domain.hid
Subject: [Xenomai-core] [PATCH] Fix attribute reference in __wrap_pthread_create
Date: Wed, 26 Sep 2007 13:38:49 +0200	[thread overview]
Message-ID: <46FA44C9.8050506@domain.hid> (raw)

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

Hi Gilles,

my rt-cap changes to the posix lib caused another regression. I don't 
understand what my intention of changing the attribute reference once 
was (probably an intermediate change), but it was wrong. The attached 
patch now makes all programs happy that create pthreads without 
attributes (clocktest e.g.).

Patch against 2.3.x, should be applied to trunk as well.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux

[-- Attachment #2: fix-pthread-attr-reference.patch --]
[-- Type: text/x-patch, Size: 1155 bytes --]

---
 ChangeLog                |    5 +++++
 src/skins/posix/thread.c |    2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

Index: xenomai-2.3.x/ChangeLog
===================================================================
--- xenomai-2.3.x.orig/ChangeLog
+++ xenomai-2.3.x/ChangeLog
@@ -1,3 +1,8 @@
+2007-09-26  Jan Kiszka  <jan.kiszka@domain.hid>
+
+	* src/skins/posix/thread.c (__wrap_pthread_create): Use the correct
+	attribute reference when creating the real pthread.
+
 2007-09-16  Philippe Gerum  <rpm@xenomai.org>
 
 	* RELEASE: Xenomai 2.3.4 (Cool #9)
Index: xenomai-2.3.x/src/skins/posix/thread.c
===================================================================
--- xenomai-2.3.x.orig/src/skins/posix/thread.c
+++ xenomai-2.3.x/src/skins/posix/thread.c
@@ -170,7 +170,7 @@ int __wrap_pthread_create(pthread_t *tid
 	iargs.ret = EAGAIN;
 	__real_sem_init(&iargs.sync, 0, 0);
 
-	err = __real_pthread_create(&ltid, &iattr, &__pthread_trampoline, &iargs);
+	err = __real_pthread_create(&ltid, attr, &__pthread_trampoline, &iargs);
 	if (!err)
 		while (__real_sem_wait(&iargs.sync) && errno == EINTR) ;
 	__real_sem_destroy(&iargs.sync);

             reply	other threads:[~2007-09-26 11:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-26 11:38 Jan Kiszka [this message]
2007-09-27  9:16 ` [Xenomai-core] [PATCH] Fix attribute reference in __wrap_pthread_create Gilles Chanteperdrix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46FA44C9.8050506@domain.hid \
    --to=jan.kiszka@domain.hid \
    --cc=Xenomai-core@domain.hid \
    --cc=gilles.chanteperdrix@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.