All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Pearson <james-p@moving-picture.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: ALSA development <alsa-devel@alsa-project.org>
Subject: Re: alsa-driver-1.0.15rc2 build issues on RHEL4/CentOS4
Date: Wed, 26 Sep 2007 12:50:58 +0100	[thread overview]
Message-ID: <46FA47A2.3020205@moving-picture.com> (raw)
In-Reply-To: <46F9353C.1040105@moving-picture.com>

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

James Pearson wrote:

> 
> I've just discovered that I can't load snd-ioctl32 from 1.0.15rc2 on 
> RHEL4/CentOS4 - dmesg reports:
> 
> snd_ioctl32: Unknown symbol snd_ctl_elem_read
> snd_ioctl32: Unknown symbol snd_ctl_elem_write
> 
> snd-ioctl32 with 1.0.15rc1 loads fine ...

The problem is still there with 1.0.15rc3 - however, I've found the 
cause of the issue:

EXPORT_SYMBOL(snd_ctl_elem_read) and EXPORT_SYMBOL(snd_ctl_elem_write) 
have been removed from alsa-kernel/core/control.c - see:

<http://hg.alsa-project.org/alsa-kernel/rev/efd5ab99655e>

I guess this is OK for more recent kernels, but still needed for 
RHEL4/CentOS4 2.6.9 kernels

I can work round the problem by putting these back into acore/control.c

I've attached a patch which patches acore/control.patch

James Pearson

[-- Attachment #2: alsa-1.0.15rc3-control_patch.patch --]
[-- Type: text/plain, Size: 1147 bytes --]

--- ./acore/control.patch.dist	2007-09-21 09:41:25.000000000 +0100
+++ ./acore/control.patch	2007-09-26 12:07:14.809107031 +0100
@@ -1,5 +1,5 @@
---- ../alsa-kernel/core/control.c	2007-05-17 08:15:24.000000000 +0200
-+++ control.c	2007-05-24 21:25:20.000000000 +0200
+--- ../alsa-kernel/core/control.c	2007-09-21 09:41:26.000000000 +0100
++++ control.c	2007-09-26 12:06:00.936446240 +0100
 @@ -1,3 +1,4 @@
 +#define __NO_VERSION__
  /*
@@ -13,7 +13,25 @@
  #include <linux/slab.h>
  #include <linux/vmalloc.h>
  #include <linux/time.h>
-@@ -1387,25 +1389,44 @@
+@@ -716,6 +718,8 @@ int snd_ctl_elem_read(struct snd_card *c
+ 	return result;
+ }
+ 
++EXPORT_SYMBOL(snd_ctl_elem_read);
++
+ static int snd_ctl_elem_read_user(struct snd_card *card,
+ 				  struct snd_ctl_elem_value __user *_control)
+ {
+@@ -779,6 +783,8 @@ int snd_ctl_elem_write(struct snd_card *
+ 	return result;
+ }
+ 
++EXPORT_SYMBOL(snd_ctl_elem_write);
++
+ static int snd_ctl_elem_write_user(struct snd_ctl_file *file,
+ 				   struct snd_ctl_elem_value __user *_control)
+ {
+@@ -1383,25 +1389,44 @@ static int snd_ctl_fasync(int fd, struct
  /*
   * ioctl32 compat
   */

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2007-09-26 11:50 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-14 10:15 alsa-driver-1.0.15rc2 build issues on RHEL4/CentOS4 James Pearson
2007-09-14 19:22 ` Takashi Iwai
2007-09-25 16:20   ` James Pearson
2007-09-26 11:50     ` James Pearson [this message]
2007-10-09 10:25       ` Takashi Iwai
2007-10-09 11:58         ` James Pearson
2007-10-09 12:59           ` Takashi Iwai
2007-10-02  9:17 ` James Pearson
2007-10-17 16:41   ` James Pearson
2007-10-18 13:57     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46FA47A2.3020205@moving-picture.com \
    --to=james-p@moving-picture.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.