All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ric Wheeler <ric@emc.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>,
	Chris Mason <chris.mason@oracle.com>, Mark Lord <mlord@pobox.com>,
	Valerie Henson <val.henson@gmail.com>,
	Christoph Hellwig <hch@infradead.org>,
	Suparna Bhattacharya <suparna@in.ibm.com>,
	Andreas Dilger <adilger@clusterfs.com>
Cc: Bob Bell <b_lkml@thebellsplace.com>,
	Matthew Wilcox <matthew@wil.cx>,
	trond@netapp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] TASK_KILLABLE version 2
Date: Wed, 26 Sep 2007 07:57:10 -0400	[thread overview]
Message-ID: <46FA4916.10103@emc.com> (raw)
In-Reply-To: <20070924201648.GA6850@newbie.thebellsplace.net>

Bob Bell wrote:
> On Sat, Sep 01, 2007 at 08:43:49PM -0600, Matthew Wilcox wrote:
>> Here's the second version of TASK_KILLABLE.  A few changes since 
>> version 1:
> <snip>
>> I obviously haven't covered every place that can result in a process
>> sleeping uninterruptibly while attempting an operation.  But sync_page
>> (patch 4/5) covers about 90% of the times I've attempted to kill cat,
>> and I hope that by providing the two examples, I can help other people
>> to fix the cases that they find interesting.
> 
> I've been testing this patch on my systems.  It's working for me when
> I read() a file.  Asynchronous write()s seem okay, too.  However,
> synchronous writes (caused by either calling fsync() or fcntl() to
> release a lock) prevent the process from being killed when the NFS
> server goes down.

After hearing again last month about how few people actually read every 
lkml thread, I  wanted to point you all at this thread explicitly since 
it seems that we are getting somewhat close to having a forced unmount 
that actually is usable by real applications, something that we seem to 
have been talking about for many years ;-)

With Matthew's original TASK_KILLABLE patch, we have a solution for a 
task read, but still have some holes (fsync & fcntl, others?) that need 
fixed as well for NFS clients.

Is this patch going in the right direction?

ric




  reply	other threads:[~2007-09-26 12:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-02  2:43 [PATCH] TASK_KILLABLE version 2 Matthew Wilcox
2007-09-02  2:46 ` [PATCH 1/5] Use wake_up_locked() in eventpoll Matthew Wilcox
2007-09-02  2:46 ` [PATCH 2/5] Use macros instead of TASK_ flags Matthew Wilcox
2007-09-02  2:54   ` Matthew Wilcox
2007-09-02  3:35   ` Daniel Walker
2007-09-02  4:05     ` Matthew Wilcox
2007-09-03 21:03   ` Matthew Wilcox
2007-09-02  2:46 ` [PATCH 3/5] Add TASK_WAKEKILL Matthew Wilcox
2007-09-02  2:46 ` [PATCH 4/5] Add lock_page_killable Matthew Wilcox
2007-09-02  2:46 ` [PATCH 5/5] Make wait_on_retry_sync_kiocb killable Matthew Wilcox
2007-09-24 20:16 ` [PATCH] TASK_KILLABLE version 2 Bob Bell
2007-09-26 11:57   ` Ric Wheeler [this message]
2007-09-27 21:47     ` Nick Piggin
2007-12-07  1:49   ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46FA4916.10103@emc.com \
    --to=ric@emc.com \
    --cc=adilger@clusterfs.com \
    --cc=b_lkml@thebellsplace.com \
    --cc=chris.mason@oracle.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mlord@pobox.com \
    --cc=nickpiggin@yahoo.com.au \
    --cc=suparna@in.ibm.com \
    --cc=trond@netapp.com \
    --cc=val.henson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.