From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Emelyanov Subject: Re: [PATCH] Remove unused member from nsproxy Date: Wed, 26 Sep 2007 17:37:18 +0400 Message-ID: <46FA608E.1060009@openvz.org> References: <46FA5B39.1010204@openvz.org> <46FA5F26.2030100@fr.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <46FA5F26.2030100@fr.ibm.com> Sender: linux-kernel-owner@vger.kernel.org To: Cedric Le Goater Cc: Andrew Morton , Linux Containers , Linux Kernel Mailing List List-Id: containers.vger.kernel.org Cedric Le Goater wrote: > Pavel Emelyanov wrote: >> The nslock spinlock is not used in the kernel at all. > > it's also useless now that you have put some RCU rules around it. > right ? Exactly! > C. > >> Remove it. >> Signed-off-by: Pavel Emelyanov >> >> --- >> >> diff --git a/include/linux/init_task.h b/include/linux/init_task.h >> index a3f2541..cae35b6 100644 >> --- a/include/linux/init_task.h >> +++ b/include/linux/init_task.h >> @@ -73,7 +73,6 @@ extern struct nsproxy init_nsproxy; >> #define INIT_NSPROXY(nsproxy) { \ >> .pid_ns = &init_pid_ns, \ >> .count = ATOMIC_INIT(1), \ >> - .nslock = __SPIN_LOCK_UNLOCKED(nsproxy.nslock), \ >> .uts_ns = &init_uts_ns, \ >> .mnt_ns = NULL, \ >> INIT_NET_NS(net_ns) \ >> diff --git a/include/linux/nsproxy.h b/include/linux/nsproxy.h >> index 4d564d8..0e66b57 100644 >> --- a/include/linux/nsproxy.h >> +++ b/include/linux/nsproxy.h >> @@ -23,7 +23,6 @@ struct pid_namespace; >> */ >> struct nsproxy { >> atomic_t count; >> - spinlock_t nslock; >> struct uts_namespace *uts_ns; >> struct ipc_namespace *ipc_ns; >> struct mnt_namespace *mnt_ns; >> _______________________________________________ >> Containers mailing list >> Containers@lists.linux-foundation.org >> https://lists.linux-foundation.org/mailman/listinfo/containers >> > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >