All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Ram Dorai <deathtofat@gmail.com>
Cc: Konrad Rzeszutek <konrad@darnok.org>,
	linux-kernel@vger.kernel.org, pjones@redhat.com,
	konradr@redhat.com, konradr@linux.vnet.ibm.com
Subject: Re: [PATCH] Add iSCSI iBFT support.
Date: Wed, 26 Sep 2007 21:00:13 -0700	[thread overview]
Message-ID: <46FB2ACD.6030107@oracle.com> (raw)
In-Reply-To: <14e4363b0709261817t5f0b1922m99c24549ce316de8@mail.gmail.com>

Ram Dorai wrote:
> 
>     Fixed.
>      > > +static int
>      > > +ibft_mmap_binary(struct kobject *kobj, struct bin_attribute
>     *attr,
>      > > +            struct vm_area_struct *vma)
>      >
> 
> 
> 
> Do we not put a space between binary and '('. Is that against the coding 
> guidelines?

Right, we do not put a space there.

It's read_binary(ko, attr, vma);

so function names have no space following them, but
if, for, switch, and while do have space following them.

-- 
~Randy
Phaedrus says that Quality is about caring.

  parent reply	other threads:[~2007-09-27  4:01 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-26 18:46 [PATCH] Add iSCSI iBFT support Konrad Rzeszutek
2007-09-26 19:37 ` roel
2007-09-26 21:10 ` Greg KH
2007-09-27  0:08   ` Konrad Rzeszutek
2007-09-27  2:04     ` Greg KH
2007-09-26 21:13 ` Randy Dunlap
2007-09-27  0:16   ` Konrad Rzeszutek
2007-09-26 21:29 ` Randy Dunlap
2007-09-27  0:52   ` Konrad Rzeszutek
     [not found]     ` <14e4363b0709261817t5f0b1922m99c24549ce316de8@mail.gmail.com>
2007-09-27  4:00       ` Randy Dunlap [this message]
2007-09-27  4:29     ` Randy Dunlap
2007-09-27 17:06     ` H. Peter Anvin
2007-09-27 17:12       ` Peter Jones
2007-09-27 17:18         ` H. Peter Anvin
2007-09-27 17:51           ` Peter Jones
2007-09-27 20:50             ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46FB2ACD.6030107@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=deathtofat@gmail.com \
    --cc=konrad@darnok.org \
    --cc=konradr@linux.vnet.ibm.com \
    --cc=konradr@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.