From: Sam Vilain <sam@vilain.net>
To: Steven Walter <stevenrwalter@gmail.com>
Cc: git@vger.kernel.org, normalperson@yhbt.net
Subject: Re: git-svn and branches
Date: Thu, 27 Sep 2007 18:36:08 +1200 [thread overview]
Message-ID: <46FB4F58.2080901@vilain.net> (raw)
In-Reply-To: <20070927021252.GA23777@dervierte>
Steven Walter wrote:
> Knowing just enough of what git-svn is doing to be dangerous, I
> whipped up a short little patch. This patch seems to work for the
> common case, and avoids fetching every file from subversion. It does
> break sometimes, however, and I don't understand why.
>
> Maybe someone with a better grasps of the code can see what I did
> wrong, or suggest a better means to my end?
Try also with the SVN trunk - the do_switch API has recently been added
and it also avoids this excess checkout. I'm not sure why a solution
like you post isn't used, perhaps Eric can comment further.
Sam.
> diff --git a/git-svn.perl b/git-svn.perl
> index 484b057..1bc92b6 100755
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -1848,9 +1848,10 @@ sub find_parent_branch {
> $self->full_url, $ed)
> or die "SVN connection failed somewhere...\n";
> } else {
> + $self->assert_index_clean($parent);
> print STDERR "Following parent with do_update\n";
> $ed = SVN::Git::Fetcher->new($self);
> - $self->ra->gs_do_update($rev, $rev, $self, $ed)
> + $self->ra->gs_do_update($rev, $r0, $self, $ed)
> or die "SVN connection failed somewhere...\n";
> }
> print STDERR "Successfully followed parent\n";
next prev parent reply other threads:[~2007-09-27 6:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 2:12 git-svn and branches Steven Walter
2007-09-27 6:36 ` Sam Vilain [this message]
2007-09-27 7:24 ` Eric Wong
2007-09-28 17:19 ` Steven Walter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FB4F58.2080901@vilain.net \
--to=sam@vilain.net \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=stevenrwalter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.