From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balbir Singh Subject: Re: [RFC}[PATCH] forced uncharge for successful rmdir. Date: Thu, 27 Sep 2007 13:45:18 +0530 Message-ID: <46FB6696.1080801@linux.vnet.ibm.com> References: <20070927163035.20137bb5.kamezawa.hiroyu@jp.fujitsu.com> Reply-To: balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070927163035.20137bb5.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: KAMEZAWA Hiroyuki Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, pbadari-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org List-Id: containers.vger.kernel.org KAMEZAWA Hiroyuki wrote: > Following patch is for successful rmdir in memory cgroup. > > Currently, rmdir against memory cgroup will fail if charged page caches are in cgroup. > (even if no tasks in cgroup.) > > I don't like this. This patch implements "forced" uncharge against memory cgroup. > Uncharged pages will be charged again when some other cgroup/task accesses it. > > I wonder that all unmapped page-caches in cgroup should be uncharged if "1" is written to > control_type. > > I'm grad if I can hear memory controller's policy about "rmdir" against no-task-cgroup. > > Thanks, > -Kame Hi, Kamezawa-San, Thanks for looking into this, I am traveling. I'll review and respond once I am back -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL