From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Shane Huang <Shane.Huang@amd.com>, bzolnier@gmail.com
Cc: linux-ide@vger.kernel.org, gregkh@suse.de, "Su,
Henry" <Henry.Su@amd.com>
Subject: Re: [patch] SB700 contains more than one IDE channel
Date: Thu, 27 Sep 2007 16:18:47 +0400 [thread overview]
Message-ID: <46FB9FA7.7090403@ru.mvista.com> (raw)
In-Reply-To: <5CAB7B5D6F8AB84AA868A46B47A5070544C164@sshaexmb1.amd.com>
Hello.
Shane Huang wrote:
> SB700 supports one physical IDE channel, but SB700 SATA controller
> supports combined mode. When the SATA combined mode is enabled,
> two SATA ports(port4 and port5) share one IDE channel from IDE
> controller, and PATA will share the other IDE channel.
> Our previous patch adding SB700 IDE device ID only support one
> IDE channel, which contains bug. The attached patch fix the bug.
> Signed-off-by: shane.huang@amd.com
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> ----------------------------------------------
> diff -ruN linux-2.6.23-rc5_orig/drivers/ide/pci/atiixp.c
> linux-2.6.23-rc5/drivers/ide/pci/atiixp.c
> --- linux-2.6.23-rc5_orig/drivers/ide/pci/atiixp.c 2007-09-01
> 14:08:24.000000000 +0800
> +++ linux-2.6.23-rc5/drivers/ide/pci/atiixp.c 2007-09-28
> 00:35:55.000000000 +0800
> @@ -325,7 +325,7 @@
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_IDE, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 0},
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_IDE, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 0},
> { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_IDE, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 1},
> - { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 1},
> + { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP700_IDE, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 0},
> { 0, },
> };
> MODULE_DEVICE_TABLE(pci, atiixp_pci_tbl);
The inlined patch has suffered from word wrapping, and the attached one
luckily didn't; yet the attachment has a wrong MIME type -- patches should be
text/plain.
MBR, Sergei
next prev parent reply other threads:[~2007-09-27 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-13 3:01 [patch] Add more device IDs for supporting ATI SB700 SATA controller completely Henry Su
2007-09-27 9:04 ` [patch] SB700 contains more than one IDE channel Shane Huang
2007-09-27 12:18 ` Sergei Shtylyov [this message]
2007-09-28 3:44 ` Shane Huang
2007-10-01 21:04 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FB9FA7.7090403@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=Henry.Su@amd.com \
--cc=Shane.Huang@amd.com \
--cc=bzolnier@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.