From: roel <12o3l@tiscali.nl>
To: mgross@linux.intel.com
Cc: Randy Dunlap <randy.dunlap@oracle.com>,
linux-pm <linux-pm@lists.linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] QoS params patch
Date: Thu, 27 Sep 2007 15:00:14 +0200 [thread overview]
Message-ID: <46FBA95E.3090207@tiscali.nl> (raw)
In-Reply-To: <20070927004020.GB29906@linux.intel.com>
Mark Gross wrote:
> On Wed, Sep 26, 2007 at 04:41:59PM -0700, Randy Dunlap wrote:
>> On Wed, 26 Sep 2007 15:40:26 -0700 Mark Gross wrote:
>>
>>> The following is the qos_param patch that implements a genralization of
>>> latency.c.
>>>
>> Just some general comments (as on irc):
>>
>> - use 'diffstat -p1 -w70' to summarize each patch
>> - use checkpatch.pl to check for coding style and other buglets
>
> done
>
>> - has no API docs :(
> not done yet.
>>
>>
>>
>>> +/* assumes qos_lock is held */
>>> +static void update_target(int i)
>> I'd prefer a better arg name than 'i'.
>
> I do too, but i in this case is an Index.
I think in many cases you could use a pointer to qos_array[i] instead of
passing this index 'i' as a function argument.
Roel
next prev parent reply other threads:[~2007-09-27 13:00 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 22:37 [RFC] QoS power Management enabling patch set Mark Gross
2007-09-26 22:40 ` [RFC] QoS params patch Mark Gross
2007-09-26 22:40 ` Mark Gross
2007-09-26 23:41 ` Randy Dunlap
2007-09-26 23:41 ` Randy Dunlap
2007-09-27 0:40 ` Mark Gross
2007-09-27 2:53 ` Valdis.Kletnieks
2007-09-27 3:18 ` Paul Mundt
2007-09-27 15:17 ` Mark Gross
2007-09-27 15:17 ` Mark Gross
2007-09-27 3:18 ` Paul Mundt
2007-09-27 15:36 ` Mark Gross
2007-09-27 15:36 ` Mark Gross
2007-09-27 2:53 ` Valdis.Kletnieks
2007-09-27 13:00 ` roel [this message]
2007-09-27 13:00 ` roel
2007-09-27 0:40 ` Mark Gross
2007-09-27 2:24 ` Paul Mundt
2007-09-27 2:24 ` Paul Mundt
2007-09-27 4:05 ` Randy Dunlap
2007-09-27 4:05 ` Randy Dunlap
2007-09-27 15:37 ` Mark Gross
2007-09-27 15:37 ` Mark Gross
2007-09-27 20:17 ` [RFC] QoS params patch update Mark Gross
2007-09-28 0:08 ` Paul Mundt
2007-09-28 0:08 ` Paul Mundt
2007-09-27 20:17 ` Mark Gross
2007-09-27 16:21 ` [RFC] QoS params patch Mark Gross
2007-09-27 16:21 ` Mark Gross
2007-09-28 6:25 ` Andrew Morton
2007-09-28 6:41 ` Paul Mundt
2007-09-28 17:22 ` Mark Gross
2007-09-28 17:22 ` Mark Gross
2007-09-28 6:41 ` Paul Mundt
2007-09-28 17:19 ` Mark Gross
2007-09-28 17:19 ` Mark Gross
2007-09-28 18:51 ` Andrew Morton
2007-09-28 18:51 ` Andrew Morton
2007-10-01 16:11 ` Mark Gross
2007-10-01 16:11 ` Mark Gross
2007-09-28 6:25 ` Andrew Morton
2007-09-26 22:42 ` [RFC] QoS power Management enabling patch set Mark Gross
2007-09-26 22:42 ` Mark Gross
2007-09-26 22:45 ` [RFC] QoS power example / hack Mark Gross
2007-09-26 22:45 ` Mark Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FBA95E.3090207@tiscali.nl \
--to=12o3l@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mgross@linux.intel.com \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.