All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
	jamal <hadi@cyberus.ca>
Subject: Re: [PKT_SCHED]: Add stateless NAT
Date: Thu, 27 Sep 2007 15:16:48 +0200	[thread overview]
Message-ID: <46FBAD40.8040806@trash.net> (raw)
In-Reply-To: <20070927131008.GA15997@2ka.mipt.ru>

Evgeniy Polyakov wrote:
> +static inline void nf_csum_replace4(__sum16 *sum, __be32 from, __be32 to)
> +{
> +	__be32 diff[] = { ~from, to };
> +
> +	*sum = csum_fold(csum_partial((char *)diff, sizeof(diff), ~csum_unfold(*sum)));
> +}
> +
> +static inline void nf_csum_replace2(__sum16 *sum, __be16 from, __be16 to)
> +{
> +	nf_csum_replace4(sum, (__force __be32)from, (__force __be32)to);
> +}
> +
> +static inline void nf_proto_csum_replace4(__sum16 *sum, struct sk_buff *skb,
> +			    __be32 from, __be32 to, int pseudohdr)
> +{
> +	__be32 diff[] = { ~from, to };
> +	if (skb->ip_summed != CHECKSUM_PARTIAL) {
> +		*sum = csum_fold(csum_partial(diff, sizeof(diff),
> +				~csum_unfold(*sum)));
> +		if (skb->ip_summed == CHECKSUM_COMPLETE && pseudohdr)
> +			skb->csum = ~csum_partial(diff, sizeof(diff),
> +						~skb->csum);
> +	} else if (pseudohdr)
> +		*sum = ~csum_fold(csum_partial(diff, sizeof(diff),
> +				csum_unfold(*sum)));
> +}
> +
> +static inline void nf_proto_csum_replace2(__sum16 *sum, struct sk_buff *skb,
> +				      __be16 from, __be16 to, int pseudohdr)
> +{
> +	nf_proto_csum_replace4(sum, skb, (__force __be32)from,
> +				(__force __be32)to, pseudohdr);
> +}


These are way too large to get inlined, please move somewhere below
net/core.

  reply	other threads:[~2007-09-27 13:17 UTC|newest]

Thread overview: 80+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-27  7:34 [PKT_SCHED]: Add stateless NAT Herbert Xu
2007-09-27  9:25 ` Evgeniy Polyakov
2007-09-27  9:33   ` Herbert Xu
2007-09-27 10:07     ` Evgeniy Polyakov
2007-09-27 10:29       ` Herbert Xu
2007-09-27 12:41         ` Evgeniy Polyakov
2007-09-27 12:45           ` Herbert Xu
2007-09-27 13:10             ` Evgeniy Polyakov
2007-09-27 13:16               ` Patrick McHardy [this message]
2007-09-27 13:25                 ` Evgeniy Polyakov
2007-09-27 13:30                   ` Patrick McHardy
2007-09-27 13:33                     ` Evgeniy Polyakov
2007-09-27 13:34                     ` jamal
2007-09-27 13:20               ` Herbert Xu
2007-09-27 13:29                 ` Evgeniy Polyakov
2007-09-27 13:39                   ` Patrick McHardy
2007-09-27 19:52                     ` David Miller
2007-09-28  8:19                       ` Evgeniy Polyakov
2007-09-28  9:16                         ` Evgeniy Polyakov
2007-09-28 16:31                       ` Patrick McHardy
2007-09-27 12:52           ` jamal
2007-09-27 13:06             ` Evgeniy Polyakov
2007-09-27 12:27     ` Herbert Xu
2007-09-27 12:46   ` jamal
2007-09-27 12:39 ` jamal
2007-09-27 12:58   ` Herbert Xu
2007-09-27 19:48     ` David Miller
2007-09-27 13:01   ` Herbert Xu
2007-09-27 13:16     ` jamal
2007-09-27 19:08   ` David Miller
2007-09-28 16:55     ` Patrick McHardy
2007-09-29  0:51       ` Herbert Xu
2007-09-29  3:37         ` Herbert Xu
2007-09-29 15:21           ` Patrick McHardy
2007-09-29 23:36             ` Herbert Xu
2007-09-30  0:13             ` David Miller
2007-09-30  0:26               ` Herbert Xu
2007-09-30  0:43                 ` Herbert Xu
2007-09-30 15:38                   ` Patrick McHardy
2007-10-14  4:26                     ` [0/10] Remove sk_buff ** from netfilter API Herbert Xu
2007-10-14  4:27                       ` [PATCH 1/10] [SKBUFF]: Merge common code between copy_skb_header and skb_clone Herbert Xu
2007-10-14 10:36                         ` jamal
2007-10-14  4:27                       ` [PATCH 2/10] [SKBUFF]: Add skb_morph Herbert Xu
2007-11-26  6:50                         ` Yasuyuki KOZAKAI
     [not found]                         ` <200711260650.lAQ6oOL9006774@toshiba.co.jp>
2007-11-26 15:10                           ` Herbert Xu
2007-11-27  6:50                             ` Yasuyuki KOZAKAI
2007-10-14  4:27                       ` [PATCH 3/10] [IPV4]: Make ip_defrag return the same packet Herbert Xu
2007-10-14  4:27                       ` [PATCH 4/10] [IPV4]: Change ip_defrag to return an integer Herbert Xu
2007-10-14  4:27                       ` [PATCH 5/10] [NET]: Avoid unnecessary cloning for ingress filtering Herbert Xu
2007-10-14 10:49                         ` jamal
2007-10-15 13:57                           ` jamal
2007-10-15 14:28                             ` Patrick McHardy
2007-10-15 14:55                             ` Alexey Kuznetsov
2007-10-16 10:28                               ` jamal
2007-10-14  4:27                       ` [PATCH 6/10] [BRIDGE]: Unshare skb upon entry Herbert Xu
2007-10-15  7:20                         ` Patrick McHardy
2007-10-15  8:04                           ` Herbert Xu
2007-10-15  8:50                           ` David Miller
2007-10-14  4:27                       ` [PATCH 7/10] [NETFILTER]: Do not copy skb in skb_make_writable Herbert Xu
2007-10-14  4:27                       ` [PATCH 8/10] [IPVS]: Replace local version of skb_make_writable Herbert Xu
2007-10-14  4:27                       ` [PATCH 9/10] [NETFILTER]: Avoid skb_copy/pskb_copy/skb_realloc_headroom Herbert Xu
2007-10-14  4:27                       ` [PATCH 10/10] [NETFILTER]: Replace sk_buff ** with sk_buff * Herbert Xu
2007-10-14  9:55                         ` Herbert Xu
2007-10-14 14:46                           ` [0/3] [IPV6]: Kill sk_buff ** usage on input path Herbert Xu
2007-10-14 14:49                             ` [PATCH 1/3] [IPV6]: Make ipv6_frag_rcv return the same packet Herbert Xu
2007-10-15  8:28                               ` David Miller
2007-10-14 14:49                             ` [PATCH 2/3] [IPV6]: Avoid skb_copy/pskb_copy/skb_realloc_headroom on input Herbert Xu
2007-10-15  8:29                               ` David Miller
2007-10-14 14:49                             ` [PATCH 3/3] [IPV6]: Replace sk_buff ** with sk_buff * in input handlers Herbert Xu
2007-10-14 15:43                               ` YOSHIFUJI Hideaki / 吉藤英明
2007-10-15  8:30                                 ` David Miller
2007-10-15  8:29                               ` David Miller
2007-10-15 14:21                                 ` Herbert Xu
2007-10-15  8:27                           ` [PATCH 10/10] [NETFILTER]: Replace sk_buff ** with sk_buff * David Miller
2007-10-15  6:25                       ` [0/10] Remove sk_buff ** from netfilter API Patrick McHardy
2007-10-15  7:57                       ` [IPV4]: Uninline netfilter okfns Patrick McHardy
2007-10-15  8:05                         ` Herbert Xu
2007-10-15  8:30                         ` [IPV6]: " Patrick McHardy
2007-10-15  8:51                           ` David Miller
2007-10-15  8:49                         ` [IPV4]: " David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46FBAD40.8040806@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=hadi@cyberus.ca \
    --cc=herbert@gondor.apana.org.au \
    --cc=johnpol@2ka.mipt.ru \
    --cc=kuznet@ms2.inr.ac.ru \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.