From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PKT_SCHED]: Add stateless NAT Date: Thu, 27 Sep 2007 15:30:12 +0200 Message-ID: <46FBB064.6070508@trash.net> References: <20070927073446.GA14643@gondor.apana.org.au> <20070927092512.GD29329@2ka.mipt.ru> <20070927093358.GA15357@gondor.apana.org.au> <20070927100753.GA22323@2ka.mipt.ru> <20070927102916.GA15749@gondor.apana.org.au> <20070927124120.GA8897@2ka.mipt.ru> <20070927124515.GA16706@gondor.apana.org.au> <20070927131008.GA15997@2ka.mipt.ru> <46FBAD40.8040806@trash.net> <20070927132507.GA25353@2ka.mipt.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Herbert Xu , "David S. Miller" , netdev@vger.kernel.org, Alexey Kuznetsov , jamal To: Evgeniy Polyakov Return-path: Received: from stinky.trash.net ([213.144.137.162]:58310 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754319AbXI0Nag (ORCPT ); Thu, 27 Sep 2007 09:30:36 -0400 In-Reply-To: <20070927132507.GA25353@2ka.mipt.ru> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Evgeniy Polyakov wrote: > On Thu, Sep 27, 2007 at 03:16:48PM +0200, Patrick McHardy (kaber@trash.net) wrote: > >> >>These are way too large to get inlined, please move somewhere below >>net/core. > > > I knew that... :) > I'm pretty sure new files called net/core/helpers.c which will host that > helper is not a good solution too? I like Herbert's suggestion of net/core/utils.c better (and without the nf_ prefix please).