All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: unlisted-recipients:; (no To-header on input)
Cc: Zang Roy-r61911 <tie-fei.zang@freescale.com>,
	Andrew Morton <akpm@osdl.org>, netdev <netdev@vger.kernel.org>,
	Kyle McMartin <kyle@mcmartin.ca>,
	Grant Grundler <grundler@parisc-linux.org>
Subject: Re: [PATCH] Clean up redundant PHY write line for ULi526x Ethernet driver
Date: Thu, 27 Sep 2007 23:36:58 -0400	[thread overview]
Message-ID: <46FC76DA.6030906@garzik.org> (raw)
In-Reply-To: <1190624262.20089.7.camel@localhost.localdomain>

Zang Roy-r61911 wrote:
> From: Roy Zang <tie-fei.zang@freescale.com>
> 
> Clean up redundant PHY write line for ULi526x Ethernet
> Driver.
> 
> Signed-off-by: Roy Zang <tie-fei.zang@freescale.com>
> ---
>  drivers/net/tulip/uli526x.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/tulip/uli526x.c b/drivers/net/tulip/uli526x.c
> index ca2548e..53a8e65 100644
> --- a/drivers/net/tulip/uli526x.c
> +++ b/drivers/net/tulip/uli526x.c
> @@ -1512,7 +1512,6 @@ static void uli526x_process_mode(struct uli526x_board_info *db)
>  			case ULI526X_100MFD: phy_reg = 0x2100; break;
>  			}
>  			phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);
> -       			phy_write(db->ioaddr, db->phy_addr, 0, phy_reg, db->chip_id);

Kyle and Grant, I'll queue this up, unless ya'll object...

	Jeff



  reply	other threads:[~2007-09-28  3:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-24  8:57 [PATCH] Clean up redundant PHY write line for ULi526x Ethernet driver Zang Roy-r61911
2007-09-28  3:36 ` Jeff Garzik [this message]
2007-09-28  3:57   ` Grant Grundler
2007-09-29  4:50 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46FC76DA.6030906@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@osdl.org \
    --cc=grundler@parisc-linux.org \
    --cc=kyle@mcmartin.ca \
    --cc=netdev@vger.kernel.org \
    --cc=tie-fei.zang@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.