Re: [PATCH 8/8] ata: add ATA_MWDMA* and ATA_SWDMA* defines

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Bartlomiej Zolnierkiewicz wrote:

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

> Index: b/include/linux/ata.h
> ===================================================================
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
> @@ -73,6 +73,19 @@ enum {
>  	ATA_PIO5		= ATA_PIO4 | (1 << 5),
>  	ATA_PIO6		= ATA_PIO5 | (1 << 6),
>  
> +	ATA_SWDMA0		= (1 << 0),
> +	ATA_SWDMA1		= ATA_SWDMA0 | (1 << 1),
> +	ATA_SWDMA2		= ATA_SWDMA1 | (1 << 2),
> +
> +	ATA_SWDMA2_ONLY		= (1 << 2),

    Hm, specially for PIIX/ICH? :-)

> +	ATA_MWDMA0		= (1 << 0),
> +	ATA_MWDMA1		= ATA_MWDMA0 | (1 << 1),
> +	ATA_MWDMA2		= ATA_MWDMA1 | (1 << 2),
> +
> +	ATA_MWDMA12_ONLY	= (1 << 1) | (1 << 2),

    For PIIX/ICH, I see...

> +	ATA_MWDMA2_ONLY		= (1 << 2),

    We still have such? Ah, must be sgiioc4...

MBR, Sergei