All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel J Walsh <dwalsh@redhat.com>
To: Todd Miller <Tmiller@tresys.com>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
	selinux@tycho.nsa.gov, Joshua Brindle <jbrindle@tresys.com>
Subject: Re: [patch 0/4] libsemanage: genhomedircon regressions
Date: Fri, 28 Sep 2007 11:15:58 -0400	[thread overview]
Message-ID: <46FD1AAE.9060905@redhat.com> (raw)
In-Reply-To: <6FE441CD9F0C0C479F2D88F959B01588010FFB75@exchange.columbia.tresys.com>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Todd Miller wrote:
> Stephen Smalley wrote:
>> Looking again at the output, the order differs - the libsemanage
>> genhomedircon puts the specific user entries first and then the
>> generic /home entries, which seems wrong given that later entries take
>> precedence for matchpathcon.  genhomedircon script does the opposite.
> 
> This change was present in the modified diff Dan sent and I preserved
> that change in the patch set.  At the time I had thought it was moved
> to make the output better match the python script but that appears not
> to be the case.
> 
> It is easy to change back but I'm sure there was a reason for the move.
> Perhaps Dan can shed some light on this.
> 
>  - todd
THe problem was the fallback_user was not determined at the time it was
being written out.  I have sent a new patch that separates out the
descovery of the fallback_user from gen_users.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iD8DBQFG/RqurlYvE4MpobMRArtLAJ9zp2AKWoO6jUvB25bYYZl19t8KwACfeA5k
XSwO4xxrQgvgvsBU10nUyBs=
=CxFA
-----END PGP SIGNATURE-----

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

  parent reply	other threads:[~2007-09-28 15:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-27 20:07 [patch 0/4] libsemanage: genhomedircon regressions Todd C. Miller
2007-09-27 20:07 ` [patch 1/4] libsemanage: validate homedir contexts Todd C. Miller
2007-09-27 20:07 ` [patch 2/4] libsemanage: fix getpw*_r usage Todd C. Miller
2007-09-27 20:07 ` [patch 3/4] libsemanage: update default user Todd C. Miller
2007-09-27 20:07 ` [patch 4/4] libsemanage: rebuild_file_context option Todd C. Miller
2007-09-28 13:36 ` [patch 0/4] libsemanage: genhomedircon regressions Stephen Smalley
2007-09-28 13:44   ` Stephen Smalley
2007-09-28 13:58     ` Daniel J Walsh
2007-09-28 13:51       ` Stephen Smalley
2007-09-28 13:55         ` Stephen Smalley
2007-09-28 15:06           ` Daniel J Walsh
2007-09-28 14:23     ` Todd Miller
2007-09-28 15:00       ` Todd Miller
2007-09-28 14:59         ` Stephen Smalley
2007-09-28 15:35           ` Joshua Brindle
2007-09-28 16:49             ` Stephen Smalley
2007-09-28 15:15       ` Daniel J Walsh [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-09-28 18:04 Todd C. Miller
2007-09-28 18:21 ` Stephen Smalley
2007-10-01 16:31 ` Daniel J Walsh
2007-10-01 17:43   ` Todd Miller
2007-10-05 14:19   ` Stephen Smalley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46FD1AAE.9060905@redhat.com \
    --to=dwalsh@redhat.com \
    --cc=Tmiller@tresys.com \
    --cc=jbrindle@tresys.com \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.