From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andres Lagar-Cavilla <andreslc@cs.toronto.edu>
Subject: Question on save/restore mfn canonicalization
Date: Fri, 28 Sep 2007 12:25:28 -0400
Message-ID: <46FD2AF8.30107@cs.toronto.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

While exploring the paravirt save/restore code path, I noted a 
(seemingly) lack of consistency between where/who canonicalizes 
something and who un-canonicalizes. For example, the guest kernel 
canonicalizes the store and console mfn's in pre_suspend, but 
xc_domain_restore uncanonicalizes them before scheduling back the 
restored guest.
The question is if there is a mandatory reason for this, or is just the 
way the code was written. Can I, e.g, fill the 
pfn_to_mfn_frame_list(_list) entries from "outside" and remove that code 
from post_suspend, or will something break?

Thanks!
Andres