All of lore.kernel.org
 help / color / mirror / Atom feed
From: Damien Le Moal <dlemoal@kernel.org>
To: Haoxiang Li <haoxiang_li2024@163.com>,
	cassel@kernel.org, mans@mansr.com, tj@kernel.org
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: sata_dwc_460ex: Fix DMA channel leak in sata_dwc_port_start()
Date: Tue, 17 Nov 2026 04:05:17 -0800	[thread overview]
Message-ID: <46a76a46-ff13-4298-b87d-22091fc8158f@kernel.org> (raw)
In-Reply-To: <20261117094903.1282096-1-haoxiang_li2024@163.com>

On 11/17/26 01:49, Haoxiang Li wrote:
> If phy_power_on() fails in sata_dwc_port_start(), the error path
> frees hsdevp without releasing the DMA channel acquired earlier.
> Add a cleanup label to release the DMA channel before freeing
> hsdevp on this failure path.
> 
> Fixes: 0f48debdb906 ("ata: sata_dwc_460ex: add phy support")
> Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>


-- 
Damien Le Moal
Western Digital Research

  parent reply	other threads:[~2026-11-17 12:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  9:49 [PATCH] ata: sata_dwc_460ex: Fix DMA channel leak in sata_dwc_port_start() Haoxiang Li
2026-11-17  9:54 ` sashiko-bot
2026-11-17 12:05 ` Damien Le Moal [this message]
2026-11-17 12:38 ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46a76a46-ff13-4298-b87d-22091fc8158f@kernel.org \
    --to=dlemoal@kernel.org \
    --cc=cassel@kernel.org \
    --cc=haoxiang_li2024@163.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mans@mansr.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.