From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mats Petersson Subject: Re: compile error of HVM pv drivers Date: Mon, 30 Jul 2007 11:13:43 +0100 Message-ID: <46adb9f6.2283420a.5ce4.1839@mx.google.com> References: <10EA09EFD8728347A513008B6B0DA77AA3EF71@pdsmsx411.ccr.corp.intel.com> <1185789517.4287.10.camel@moonstone.uk.level5networks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed Return-path: In-Reply-To: <1185789517.4287.10.camel@moonstone.uk.level5networks.com> References: <10EA09EFD8728347A513008B6B0DA77AA3EF71@pdsmsx411.ccr.corp.intel.com> <1185789517.4287.10.camel@moonstone.uk.level5networks.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Kieran Mansley , "Zhao, Yunfeng" Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org At 10:58 30/07/2007, Kieran Mansley wrote: >On Mon, 2007-07-30 at 17:28 +0800, Zhao, Yunfeng wrote: > > With gcc 3.4.2 I got following errors while compiling HVM pv drivers > > against xen unstable 15651. > > ################# > > /xen-3.0-hg-xen_unstable_pae-15651-20070727/unmodified_drivers/linux-2.6 > > /netfront/accel.c: In function `accelerator_remove_hooks': > > xen-3.0-hg-xen_unstable_pae-15651-20070727/unmodified_drivers/linux-2.6/ > > netfront/accel.c:495: error: syntax error before "do" > > xen-3.0-hg-xen_unstable_pae-15651-20070727/unmodified_drivers/linux-2.6/ > > netfront/accel.c:495: error: syntax error before ')' token > > ################### > > But on rhel5 (gcc 4.1.1), the build can pass without any error. > >Curious. Can you post what code you have at that line. In my recent >checkout it looks like this: > >490: list_for_each_entry_safe(vif_state, tmp, >491: &accelerator->vif_states, >492: link) { >493: /* Make sure there are no data path operations going on */ >494: netif_poll_disable(vif_state->np->netdev); >495: netif_tx_lock_bh(vif_state->np->netdev); Unless one of those lines is a macro that uses the "do { ... } while(0)" trick, perhaps - how about looking at the preprocessor output for those lines? -- Mats >Which doesn't seem to match the error you're getting. No "do" for >example. > >I'll try and reproduce it, but haven't seen this before, and the nearest >gcc version I have easily to hand is 3.4.3 > >Kieran > > >_______________________________________________ >Xen-devel mailing list >Xen-devel@lists.xensource.com >http://lists.xensource.com/xen-devel