RE: [PATCH] wifi: rtl8xxxu: update rate mask per sta

[Ping-Ke Shih <pkshih@realtek.com>]

> -----Original Message-----
> From: Martin Kaistra <martin.kaistra@linutronix.de>
> Sent: Monday, January 22, 2024 5:30 PM
> To: Ping-Ke Shih <pkshih@realtek.com>; linux-wireless@vger.kernel.org
> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Kalle Valo <kvalo@kernel.org>; Bitterblue Smith
> <rtl8821cerfe2@gmail.com>; Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Subject: Re: [PATCH] wifi: rtl8xxxu: update rate mask per sta
> 
> Am 18.01.24 um 02:37 schrieb Ping-Ke Shih:
> >
> >
> >> -----Original Message-----
> >> From: Martin Kaistra <martin.kaistra@linutronix.de>
> >> Sent: Wednesday, January 17, 2024 10:55 PM
> >> To: linux-wireless@vger.kernel.org
> >> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Kalle Valo <kvalo@kernel.org>; Ping-Ke Shih
> >> <pkshih@realtek.com>; Bitterblue Smith <rtl8821cerfe2@gmail.com>; Sebastian Andrzej Siewior
> >> <bigeasy@linutronix.de>
> >> +
> >> +       sta = ieee80211_find_sta_by_ifaddr(priv->hw, hdr->addr2,
> >> +                                          vif->addr);
> >
> > Can't we search for 'sta' by rx_desc->mac_id? Then, you don't need a lot of
> > code to check address.
> 
> I assume, you mean rx_desc->macid? When I try to test this, it looks to me as if
> the assignment of macid to sta in rx does not match the assignment in the driver.
> For example, I expect the first connected station to be macid 2, which is also
> sent to the firmware by report_connect, but in rxdesc it is macid 1. Can this
> even be influenced by the driver?

The rx_desc->macid is not always usable for this generation chips, so just your
original logic.