From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH v4] drm/amdgpu: Transfer fences to dmabuf importer Date: Tue, 7 Aug 2018 20:18:55 +0200 Message-ID: <46b0cdd8-ebe5-bcf2-9fdc-4098c4a46fd5@gmail.com> References: <20180807104500.31264-1-chris@chris-wilson.co.uk> <20180807160841.31028-1-chris@chris-wilson.co.uk> <100b177c-6bf2-ebaa-472a-8f3ba0228cb9@amd.com> <153366565953.5149.5039565484276598325@skylake-alporthouse-com> Reply-To: christian.koenig-5C7GfCeVMHo@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <153366565953.5149.5039565484276598325@skylake-alporthouse-com> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Chris Wilson , =?UTF-8?Q?Christian_K=c3=b6nig?= , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, intel-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Alex Deucher , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org QW0gMDcuMDguMjAxOCB1bSAyMDoxNCBzY2hyaWViIENocmlzIFdpbHNvbjoKPiBRdW90aW5nIENo cmlzdGlhbiBLw7ZuaWcgKDIwMTgtMDgtMDcgMTg6NTc6MTYpCj4+IEFtIDA3LjA4LjIwMTggdW0g MTg6MDggc2NocmllYiBDaHJpcyBXaWxzb246Cj4+PiBhbWRncHUgb25seSB1c2VzIHNoYXJlZC1m ZW5jZXMgaW50ZXJuYWxseSwgYnV0IGRtYWJ1ZiBpbXBvcnRlcnMgcmVseSBvbgo+Pj4gaW1wbGlj aXQgd3JpdGUgaGF6YXJkIHRyYWNraW5nIHZpYSB0aGUgcmVzZXJ2YXRpb25fb2JqZWN0LmZlbmNl X2V4Y2wuCj4+PiBGb3IgZXhhbXBsZSwgdGhlIGltcG9ydGVyIHVzZSB0aGUgd3JpdGUgaGF6YXJk IGZvciB0aW1pbmcgYSBwYWdlIGZsaXAgdG8KPj4+IG9ubHkgb2NjdXIgYWZ0ZXIgdGhlIGV4cG9y dGVyIGhhcyBmaW5pc2hlZCBmbHVzaGluZyBpdHMgd3JpdGUgaW50byB0aGUKPj4+IHN1cmZhY2Uu IEFzIHN1Y2gsIG9uIGV4cG9ydGluZyBhIGRtYWJ1Ziwgd2UgbXVzdCBlaXRoZXIgZmx1c2ggYWxs Cj4+PiBvdXRzdGFuZGluZyBmZW5jZXMgKGZvciB3ZSBkbyBub3Qga25vdyB3aGljaCBhcmUgd3Jp dGVzIGFuZCBzaG91bGQgaGF2ZQo+Pj4gYmVlbiBleGNsdXNpdmUpIG9yIGFsdGVybmF0aXZlbHkg Y3JlYXRlIGEgbmV3IGV4Y2x1c2l2ZSBmZW5jZSB0aGF0IGlzCj4+PiB0aGUgY29tcG9zaXRlIG9m IGFsbCB0aGUgZXhpc3Rpbmcgc2hhcmVkIGZlbmNlcywgYW5kIHNvIHdpbGwgb25seSBiZQo+Pj4g c2lnbmFsZWQgd2hlbiBhbGwgZWFybGllciBmZW5jZXMgYXJlIHNpZ25hbGVkIChlbnN1cmluZyB0 aGF0IHdlIGNhbiBub3QKPj4+IGJlIHNpZ25hbGVkIGJlZm9yZSB0aGUgY29tcGxldGlvbiBvZiBh bnkgZWFybGllciB3cml0ZSkuCj4+Pgo+Pj4gdjI6IHJlc2VydmF0aW9uX29iamVjdCBpcyBhbHJl YWR5IGxvY2tlZCBieSBhbWRncHVfYm9fcmVzZXJ2ZSgpCj4+Pgo+Pj4gQnVnemlsbGE6IGh0dHBz Oi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzM0MQo+Pj4gVGVzdGNh c2U6IGlndC9hbWRfcHJpbWUvYW1kLXRvLWk5MTUKPj4+IFJlZmVyZW5jZXM6IDhlOTRhNDZjMTc3 MCAoImRybS9hbWRncHU6IEF0dGFjaCBleGNsdXNpdmUgZmVuY2UgdG8gcHJpbWUgZXhwb3J0ZWQg Ym8ncy4gKHY1KSIpCj4+PiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlz LXdpbHNvbi5jby51az4KPj4+IENjOiBBbGV4IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFt ZC5jb20+Cj4+PiBDYzogIkNocmlzdGlhbiBLw7ZuaWciIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5j b20+Cj4+PiAtLS0KPj4+Cj4+PiBUaGlzIHRpbWUsIGhvcGVmdWxseSBwcm9vZnJlYWQgYW5kIHJl ZmVyZW5jZXMgY29tcGxldGUuCj4+PiAtQ2hyaXMKPj4+Cj4+PiAtLS0KPj4+ICAgIGRyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9wcmltZS5jIHwgNjggKysrKysrKysrKysrKysrKysr KystLS0KPj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCA2MCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9u cygtKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRn cHVfcHJpbWUuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9wcmltZS5jCj4+ PiBpbmRleCAxYzVkOTdmNGI0ZGQuLmRmZjJiMDFhM2Q4OSAxMDA2NDQKPj4+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9wcmltZS5jCj4+PiArKysgYi9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfcHJpbWUuYwo+Pj4gQEAgLTM3LDYgKzM3LDcgQEAKPj4+ ICAgICNpbmNsdWRlICJhbWRncHVfZGlzcGxheS5oIgo+Pj4gICAgI2luY2x1ZGUgPGRybS9hbWRn cHVfZHJtLmg+Cj4+PiAgICAjaW5jbHVkZSA8bGludXgvZG1hLWJ1Zi5oPgo+Pj4gKyNpbmNsdWRl IDxsaW51eC9kbWEtZmVuY2UtYXJyYXkuaD4KPj4+ICAgIAo+Pj4gICAgc3RhdGljIGNvbnN0IHN0 cnVjdCBkbWFfYnVmX29wcyBhbWRncHVfZG1hYnVmX29wczsKPj4+ICAgIAo+Pj4gQEAgLTE4OCw2 ICsxODksNTcgQEAgYW1kZ3B1X2dlbV9wcmltZV9pbXBvcnRfc2dfdGFibGUoc3RydWN0IGRybV9k ZXZpY2UgKmRldiwKPj4+ICAgICAgICByZXR1cm4gRVJSX1BUUihyZXQpOwo+Pj4gICAgfQo+Pj4g ICAgCj4+PiArc3RhdGljIGludAo+Pj4gK19fcmVzZXJ2YXRpb25fb2JqZWN0X21ha2VfZXhjbHVz aXZlKHN0cnVjdCByZXNlcnZhdGlvbl9vYmplY3QgKm9iaikKPj4+ICt7Cj4+PiArICAgICBzdHJ1 Y3QgcmVzZXJ2YXRpb25fb2JqZWN0X2xpc3QgKmZvYmo7Cj4+PiArICAgICBzdHJ1Y3QgZG1hX2Zl bmNlX2FycmF5ICphcnJheTsKPj4+ICsgICAgIHN0cnVjdCBkbWFfZmVuY2UgKipmZW5jZXM7Cj4+ PiArICAgICB1bnNpZ25lZCBpbnQgY291bnQsIGk7Cj4+PiArCj4+PiArICAgICBmb2JqID0gcmVz ZXJ2YXRpb25fb2JqZWN0X2dldF9saXN0KG9iaik7Cj4+PiArICAgICBpZiAoIWZvYmopCj4+PiAr ICAgICAgICAgICAgIHJldHVybiAwOwo+Pj4gKwo+Pj4gKyAgICAgY291bnQgPSAhIXJjdV9hY2Nl c3NfcG9pbnRlcihvYmotPmZlbmNlX2V4Y2wpOwo+Pj4gKyAgICAgY291bnQgKz0gZm9iai0+c2hh cmVkX2NvdW50Owo+Pj4gKwo+Pj4gKyAgICAgZmVuY2VzID0ga21hbGxvY19hcnJheShjb3VudCwg c2l6ZW9mKCpmZW5jZXMpLCBHRlBfS0VSTkVMKTsKPj4+ICsgICAgIGlmICghZmVuY2VzKQo+Pj4g KyAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKPj4+ICsKPj4+ICsgICAgIGZvciAoaSA9IDA7 IGkgPCBmb2JqLT5zaGFyZWRfY291bnQ7IGkrKykgewo+Pj4gKyAgICAgICAgICAgICBzdHJ1Y3Qg ZG1hX2ZlbmNlICpmID0KPj4+ICsgICAgICAgICAgICAgICAgICAgICByY3VfZGVyZWZlcmVuY2Vf cHJvdGVjdGVkKGZvYmotPnNoYXJlZFtpXSwKPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHJlc2VydmF0aW9uX29iamVjdF9oZWxkKG9iaikpOwo+Pj4g Kwo+Pj4gKyAgICAgICAgICAgICBmZW5jZXNbaV0gPSBkbWFfZmVuY2VfZ2V0KGYpOwo+Pj4gKyAg ICAgfQo+Pj4gKwo+Pj4gKyAgICAgaWYgKHJjdV9hY2Nlc3NfcG9pbnRlcihvYmotPmZlbmNlX2V4 Y2wpKSB7Cj4+PiArICAgICAgICAgICAgIHN0cnVjdCBkbWFfZmVuY2UgKmYgPQo+Pj4gKyAgICAg ICAgICAgICAgICAgICAgIHJjdV9kZXJlZmVyZW5jZV9wcm90ZWN0ZWQob2JqLT5mZW5jZV9leGNs LAo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgcmVz ZXJ2YXRpb25fb2JqZWN0X2hlbGQob2JqKSk7Cj4+PiArCj4+PiArICAgICAgICAgICAgIGZlbmNl c1tpXSA9IGRtYV9mZW5jZV9nZXQoZik7Cj4+PiArICAgICB9Cj4+PiArCj4+PiArICAgICBhcnJh eSA9IGRtYV9mZW5jZV9hcnJheV9jcmVhdGUoY291bnQsIGZlbmNlcywKPj4+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBkbWFfZmVuY2VfY29udGV4dF9hbGxvYygxKSwgMCwK Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmYWxzZSk7Cj4+PiArICAg ICBpZiAoIWFycmF5KQo+Pj4gKyAgICAgICAgICAgICBnb3RvIGVycl9mZW5jZXNfcHV0Owo+Pj4g Kwo+Pj4gKyAgICAgcmVzZXJ2YXRpb25fb2JqZWN0X2FkZF9leGNsX2ZlbmNlKG9iaiwgJmFycmF5 LT5iYXNlKTsKPj4+ICsgICAgIHJldHVybiAwOwo+Pj4gKwo+Pj4gK2Vycl9mZW5jZXNfcHV0Ogo+ Pj4gKyAgICAgZm9yIChpID0gMDsgaSA8IGNvdW50OyBpKyspCj4+PiArICAgICAgICAgICAgIGRt YV9mZW5jZV9wdXQoZmVuY2VzW2ldKTsKPj4+ICsgICAgIGtmcmVlKGZlbmNlcyk7Cj4+PiArICAg ICByZXR1cm4gLUVOT01FTTsKPj4+ICt9Cj4+PiArCj4+IFRoaXMgY2FuIGJlIHNpbXBsaWZpZWQg YSBsb3QuIFNlZSBhbWRncHVfcGFzaWRfZnJlZV9kZWxheWVkKCkgZm9yIGFuCj4+IGV4YW1wbGU6 Cj4gewo+IAlpZiAoIXJlc2VydmF0aW9uX29iamVjdF9nZXRfbGlzdChvYmopKQo+IAkJcmV0dXJu IDA7Cj4KPiAJciA9IHJlc2VydmF0aW9uX29iamVjdF9nZXRfZmVuY2VzX3JjdShvYmosIE5VTEws ICZjb3VudCwgJmZlbmNlcyk7Cj4gCWlmIChyKQo+IAkJcmV0dXJuIHI7Cj4KPiAJYXJyYXkgPSBk bWFfZmVuY2VfYXJyYXlfY3JlYXRlKGNvdW50LCBmZW5jZXMsCj4gCQkJCSAgICAgICBkbWFfZmVu Y2VfY29udGV4dF9hbGxvYygxKSwgMCwKPiAJCQkJICAgICAgIGZhbHNlKTsKPiAJaWYgKCFhcnJh eSkKPiAJCWdvdG8gZXJyX2ZlbmNlc19wdXQ7Cj4KPiAJcmVzZXJ2YXRpb25fb2JqZWN0X2FkZF9l eGNsX2ZlbmNlKG9iaiwgJmFycmF5LT5iYXNlKTsKPiAJcmV0dXJuIDA7Cj4KPiBlcnI6Cj4gCS4u Lgo+IH0KPgo+IE15IHN0YXJ0aW5nIHBvaW50IHdhcyBnb2luZyB0byBiZSB1c2UgZ2V0X2ZlbmNl c19yY3UsIGJ1dCBnZXRfZmVuY2VzX3JjdQo+IGNhbiBoYXJkbHkgYmUgY2FsbGVkIHNpbXBsZSBm b3Igd2hlcmUgdGhlIGxvY2sgaXMgcmVxdWlyZWQgdG8gYmUgaGVsZAo+IHN0YXJ0IHRvIGZpbmlz aCA7KQoKV2hhdCBhcmUgeW91IHRhbGtpbmcgYWJvdXQ/IGdldF9mZW5jZXNfcmN1IGRvZXNuJ3Qg cmVxdWlyZSBhbnkgbG9ja2luZyAKYXQgYWxsLgoKWW91IG9ubHkgbmVlZCB0byB0aGUgbG9ja2lu ZyB0byBtYWtlIHN1cmUgdGhhdCBiZXR3ZWVuIGNyZWF0aW5nIHRoZSAKZmVuY2UgYXJyYXkgYW5k IGNhbGxpbmcgcmVzZXJ2YXRpb25fb2JqZWN0X2FkZF9leGNsX2ZlbmNlKCkgbm8gb3RoZXIgCmZl bmNlIGlzIGFkZGVkLgoKQ2hyaXN0aWFuLgoKPiAtQ2hyaXMKPiBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4gYW1k LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vYW1kLWdmeAo=