Re: [PATCH] tdfxfb: mtrr support (2nd revision)

["Krzysztof Helt" <krzysztof.h1@wp.pl>]

Dnia 2-08-2007 o godz. 19:56 Geert Uytterhoeven napisa³(a):
> On Tue, 31 Jul 2007, Krzysztof Helt wrote:
> >  
> > +	default_par->mtrr_handle = -1;
> > +	if (!nomtrr)
> > +		default_par->mtrr_handle =
> > +			mtrr_add(tdfx_fix.smem_start, tdfx_fix.smem_len,
> > +				 MTRR_TYPE_WRCOMB, 1);
> > +
> 
> ... but everything works nicely, because no callers of 
mttr_{add,del}()
> check for actual errors ;-)
> 
>

Actually, there is an indirect check. The mttr handle is freed 
only if mtrr_add returned no error value. That's why the mtrr_add 
"dummy" must return an error.

I agree, that I do not print any message that inform about 
failure of mtrr_add, but any other fb driver does not, either. I 
think the message does not make any sense (as the CPU may be not 
able to handle this - early x86 - or the mttr is disable in 
config - require more ifdefs for messages).

Regards,
Krzysztof

----------------------------------------------------
06.10.07. Sensation White, Hala Ludowa, Wroc³aw 
Wyst±pi±: Michael Burian, Angelo Mike & John Hetmond,
Sebastian Ingrosso, David Guetta, Markus Schulz, Sander Van Doorn.
Ostatnia pula biletów: http://klik.wp.pl/?adr=http%3A%2F%2Fadv.reklama.wp.pl%2Fas%2Fwhites.html&sid=1245



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/