From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Krzysztof Helt" Subject: Re: [PATCH] sgalaxy: checkpatch fixes Date: Wed, 05 Sep 2007 15:34:03 +0200 Message-ID: <46deb04bbc13d@wp.pl> References: <20070904234925.d96c021c.krzysztof.h1@wp.pl><46DDDB21.9000003@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mx1.wp.pl (mx1.wp.pl [212.77.101.5]) by alsa0.perex.cz (Postfix) with ESMTP id 8C4DE2437D for ; Wed, 5 Sep 2007 15:34:04 +0200 (CEST) In-reply-to: <20070904234925.d96c021c.krzysztof.h1@wp.pl><46DDDB21.9000003@gmail.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Takashi Iwai Cc: Alsa-devel , Rene Herman List-Id: alsa-devel@alsa-project.org Dnia 5-09-2007 o godz. 15:20 Takashi Iwai napisa=B3(a): > At Wed, 05 Sep 2007 00:24:33 +0200, > Rene Herman wrote: > > > -#if 0 > > > - snd_printdd("WSS signature =3D 0x%x\n", tmp); > > > -#endif > > = > > Please don't just kill debug code. It's very useful for the next person = > > stepping in -- it's "functional commentary". > = > Then let's get rid of "#if 0". snd_printdd() won't get compiled > unless CONFIG_SND_DEBUG_DETECT is set, so there is no reason to kill > twice. > = I have thought the same this morning. Ok. Now I am confused. Should I fix the patch and post it or should I do nothing with the sgalaxy.c as it will be (hopefully) soon replaced by a new driver (Rene's)? Regards, Krzysztof ---------------------------------------------------- Walka jakiej nie widzia=B3e=B6! KSW eliminacje, = nie wszyscy przejd=B1 ca=B3o! = Zobacz na =BFywo we Wroc=B3awiu ju=BF 15 wrze=B6nia. = Wi=EAcej -> http://klik.wp.pl/?adr=3Dhttp%3A%2F%2Fadv.reklama.wp.pl%2Fas%2F= ksweliminacje.html&sid=3D12