From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F095C433F5 for ; Mon, 2 May 2022 12:55:13 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-35-YfLlt_e_OWKEzhrWVqnHgw-1; Mon, 02 May 2022 08:55:08 -0400 X-MC-Unique: YfLlt_e_OWKEzhrWVqnHgw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 13AFB83396D; Mon, 2 May 2022 12:55:07 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2357141636D; Mon, 2 May 2022 12:55:06 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id D2753194705F; Mon, 2 May 2022 12:55:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id 1E209194705F for ; Mon, 2 May 2022 12:55:05 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id EEC881121339; Mon, 2 May 2022 12:55:04 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E9D1C111CB81 for ; Mon, 2 May 2022 12:55:01 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9C7DF811E80 for ; Mon, 2 May 2022 12:55:01 +0000 (UTC) Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-107-yWrSItCJM7S2Wjtp2kv2_Q-1; Mon, 02 May 2022 08:55:00 -0400 X-MC-Unique: yWrSItCJM7S2Wjtp2kv2_Q-1 X-IronPort-AV: E=Sophos;i="5.91,192,1647273600"; d="scan'208";a="311307272" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 02 May 2022 20:54:58 +0800 IronPort-SDR: KGw9tuP2XbTHWhGyCDvoMK0cswBqYbIBDy1y0iUx4Xo5Nq2SyGBxq2ISy4m0yahwNXWGnsgdPw ppWy0NYEzgFVa0ng85UinN3636NhUvvZl/Uv8WEQ/MIk0s5udQfgh7IzMu31fxeIUw/7rrOIkC hmuKxGJGiuf4+QHJZ4y3vZeKT9b139i3RPWwwkKhhCpTmxtviMVWKHsOmkW7FXW7UMY1/MLkx/ RFA21EQOubm2/UpLEU3ZsXfegC9NDnGcZxTaGhaGsnvX4B0oxgqgsl6M6MI9ES6mYFem3wF8u/ 9JrmEZwk67UsmEx6F5ZJOqwT Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2022 05:25:44 -0700 IronPort-SDR: yMjJettRbffxAcP7A9aFv3f923kn+1nlK/EElOlzKe+Ngj4uWcpfX+U0idGBcQ9sD4d1LMzRny BXzFOOdqKROuIZUvWjnwjkrx0fmuStlpGt+tyfyE+SZFcS7EAB7GqHK9QkWQv9W1RWBPJzCafH /2sMv9azA0hVbcU3kEdmvRxqBwPJglvO3dBcKI2wTAtX+AFYC24RPlshwvunr8TTB5MqjXv89N imAUxO7Z5QELGMUP4qVWbKm1/11cuiNsrApC0jycMBYfC/oSrmIUvP0MHdrm2ISfydYWF1eP/h MUA= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2022 05:54:59 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KsNNL1Lfbz1SVnx for ; Mon, 2 May 2022 05:54:58 -0700 (PDT) X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id bKndW2usBH8N for ; Mon, 2 May 2022 05:54:57 -0700 (PDT) Received: from [10.225.81.200] (hq6rw33.ad.shared [10.225.81.200]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KsNNJ5Mpmz1Rvlc; Mon, 2 May 2022 05:54:56 -0700 (PDT) Message-ID: <46e95412-9a79-51f8-3d52-caed4875d41f@opensource.wdc.com> Date: Mon, 2 May 2022 21:54:55 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 To: Dave Chinner , Nitesh Shetty References: <20220426101241.30100-1-nj.shetty@samsung.com> <6a85e8c8-d9d1-f192-f10d-09052703c99a@opensource.wdc.com> <20220427124951.GA9558@test-zns> <20220502040951.GC1360180@dread.disaster.area> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220502040951.GC1360180@dread.disaster.area> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 Subject: Re: [dm-devel] [PATCH v4 00/10] Add Copy offload support X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-scsi@vger.kernel.org, nitheshshetty@gmail.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org Errors-To: dm-devel-bounces@redhat.com Sender: "dm-devel" X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 T24gMjAyMi8wNS8wMiAxMzowOSwgRGF2ZSBDaGlubmVyIHdyb3RlOgo+IE9uIFdlZCwgQXByIDI3 LCAyMDIyIGF0IDA2OjE5OjUxUE0gKzA1MzAsIE5pdGVzaCBTaGV0dHkgd3JvdGU6Cj4+IE8gV2Vk LCBBcHIgMjcsIDIwMjIgYXQgMTE6MTk6NDhBTSArMDkwMCwgRGFtaWVuIExlIE1vYWwgd3JvdGU6 Cj4+PiBPbiA0LzI2LzIyIDE5OjEyLCBOaXRlc2ggU2hldHR5IHdyb3RlOgo+Pj4+IFRoZSBwYXRj aCBzZXJpZXMgY292ZXJzIHRoZSBwb2ludHMgZGlzY3Vzc2VkIGluIE5vdmVtYmVyIDIwMjEgdmly dHVhbCBjYWxsCj4+Pj4gW0xTRi9NTS9CRlAgVE9QSUNdIFN0b3JhZ2U6IENvcHkgT2ZmbG9hZFsw XS4KPj4+PiBXZSBoYXZlIGNvdmVyZWQgdGhlIEluaXRpYWwgYWdyZWVkIHJlcXVpcmVtZW50cyBp biB0aGlzIHBhdGNoc2V0Lgo+Pj4+IFBhdGNoc2V0IGJvcnJvd3MgTWlrdWxhcydzIHRva2VuIGJh c2VkIGFwcHJvYWNoIGZvciAyIGJkZXYKPj4+PiBpbXBsZW1lbnRhdGlvbi4KPj4+Pgo+Pj4+IE92 ZXJhbGwgc2VyaWVzIHN1cHBvcnRzIOKAkwo+Pj4+Cj4+Pj4gMS4gRHJpdmVyCj4+Pj4gLSBOVk1l IENvcHkgY29tbWFuZCAoc2luZ2xlIE5TKSwgaW5jbHVkaW5nIHN1cHBvcnQgaW4gbnZtZS10YXJn ZXQgKGZvcgo+Pj4+ICAgICBibG9jayBhbmQgZmlsZSBiYWNrZW5kKQo+Pj4KPj4+IEl0IHdvdWxk IGFsc28gYmUgbmljZSB0byBoYXZlIGNvcHkgb2ZmbG9hZCBlbXVsYXRpb24gaW4gbnVsbF9ibGsg Zm9yIHRlc3RpbmcuCj4+Pgo+Pgo+PiBXZSBjYW4gcGxhbiB0aGlzIGluIG5leHQgcGhhc2Ugb2Yg Y29weSBzdXBwb3J0LCBvbmNlIHRoaXMgc2VyaWVzIHNldHRsZXMgZG93bi4KPiAKPiBXaHkgbm90 IGp1c3QgaG9vayB0aGUgbG9vcGJhY2sgZHJpdmVyIHVwIHRvIGNvcHlfZmlsZV9yYW5nZSgpIHNv Cj4gdGhhdCB0aGUgYmFja2VuZCBmaWxlc3lzdGVtIGNhbiBqdXN0IHJlZmxpbmsgY29weSB0aGUg cmFuZ2VzIGJlaW5nCj4gcGFzc2VkPyBUaGF0IHdvdWxkIGVuYWJsZSB0ZXN0aW5nIG9uIGJ0cmZz LCBYRlMgYW5kIE5GU3Y0LjIgaG9zdGVkCj4gaW1hZ2UgZmlsZXMgd2l0aG91dCBuZWVkaW5nIGFu eSBzcGVjaWFsIGJsb2NrIGRldmljZSBzZXR1cCBhdCBhbGwuLi4KClRoYXQgaXMgYSB2ZXJ5IGdv b2QgaWRlYSAhIEJ1dCB0aGF0IHdpbGwgY292ZXIgb25seSB0aGUgbm9uLXpvbmVkIGNhc2UuIEZv ciBjb3B5Cm9mZmxvYWQgb24gem9uZWQgZGV2aWNlcywgYWRkaW5nIHN1cHBvcnQgaW4gbnVsbF9i bGsgaXMgcHJvYmFibHkgdGhlIHNpbXBsZXN0CnRoaW5nIHRvIGRvLgoKPiAKPiBpLmUuIEkgdGhp bmsgeW91J3JlIGRvaW5nIHRoaXMgY29tcGVsdGVseSBiYWNrd2FyZHMgYnkgdHJ5aW5nIHRvCj4g dGFyZ2V0IG5vbi1leGlzdGVudCBoYXJkd2FyZSBmaXJzdC4uLi4KPiAKPiBDaGVlcnMsCj4gCj4g RGF2ZS4KCgotLSAKRGFtaWVuIExlIE1vYWwKV2VzdGVybiBEaWdpdGFsIFJlc2VhcmNoCgotLQpk bS1kZXZlbCBtYWlsaW5nIGxpc3QKZG0tZGV2ZWxAcmVkaGF0LmNvbQpodHRwczovL2xpc3RtYW4u cmVkaGF0LmNvbS9tYWlsbWFuL2xpc3RpbmZvL2RtLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FE0DC433EF for ; Mon, 2 May 2022 12:55:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231821AbiEBM6f (ORCPT ); Mon, 2 May 2022 08:58:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1385149AbiEBM6c (ORCPT ); Mon, 2 May 2022 08:58:32 -0400 Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23A4A140BC for ; Mon, 2 May 2022 05:54:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1651496098; x=1683032098; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=JUhkvda0JEwXdsLju2Qm64dHW4RVR82QZ/jIjIRhXSc=; b=KCyZ3l+vT77Yo1dHkfrzgWgyXAIhlO/gxXppc/zwmEmlD8vKOrjzMyv3 83ZcaJ22RCr5bs4qAXpk8gJJtZLWl/XwQgaDvc9EuTrUkM4+1TMyJUF2+ uzDd8LL0BVWIFvG+vA/yY9H2Cv6BiQmtDzeFgxTgs2rPPchtmaIN5TMEK 8N6stNS1Yf26HYu1gjqdzk6MGyLKjoAKyapUIj+O5t24PoLVrisyQB6O/ MRTU83hFbMw1Sq/tDFsMKd8r+YNbXiaja4wDOZ9M/g5Bh0ztxdre4opIc jHpN1jnH1y6fTJE33XJG7Qis4xglAO6QhEFEyDQF7NutEdW4paPSPmus1 Q==; X-IronPort-AV: E=Sophos;i="5.91,192,1647273600"; d="scan'208";a="204205550" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 02 May 2022 20:54:58 +0800 IronPort-SDR: 8Je7KGf029SxZW+779CyPv/YGCz1MtTjpXPdolnTYyF4zVJVh26h/lV8aO4tRs3m/KdjMMZdDV Bsc3t6HTA0exrsSuBMQCjtQbbgLOJArwUvKl9IHLv+5rb6Yp7jXPUcVfltPplnWJQFjYAiiTzD uqqCd11cB7h0nyUA8MSQTyH5Mg/cwvBJdDhhd0/YW7lDvcVo95ggZkRYzrn9MPLO9JlleU7oHk W3vCtAK8Xv84uaT2EAOYevWsEh+2n6cE8X8YUW29QiReOikvJ86tCrfquJDQ2NNsnIxcpoaHQw 0zSl5Z2PaHL+V3WBrgEHssQ4 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2022 05:25:02 -0700 IronPort-SDR: X/mjDqfPpuofgpIpf4bo2zbOFqdjYmlyKjFST6cdH+TbHgaPMFjssBT93mltFpRb5c47qHNtZm YAiA9tpgsulzd5Vkfu66ILIp8nOkPttgmSlxD899UgKC5kV/f7cIivuMrwseIe0hAc6VlYGraQ +zpc5r/Hi1+NKGjXeIWs2poISM3Zbv2n1mgZJKF/sj7qBJf6/oVh71K/xfUzwBl9uNjG1g1UC8 AZEABALRVBdH9l8qc2UW309TBpy6ieUH2udyJMFfdEWVeH+wQ7EmAdBSMJzkx0mMx7Jubc300+ LGE= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 02 May 2022 05:54:59 -0700 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4KsNNL0xPWz1Rwrw for ; Mon, 2 May 2022 05:54:58 -0700 (PDT) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1651496097; x=1654088098; bh=JUhkvda0JEwXdsLju2Qm64dHW4RVR82QZ/j IjIRhXSc=; b=AIzuKRzwZQVGatHl1N9EZyzvTE342Ex2Xsdk8dBzDQ7YlT68E2V jV+TRKCrZd4GXYnfbCwGUwR95UrtQKr2UfhYl8T65OJz4IyX5umhChjtkVGNhb78 fifJnXe4HbDMbtWoKXkttpTB62VrmW8Nx3y8woeYDf4X2F5K5ujyv36d1+FWxt7o sb9+KnDWiv764wZ2QpUYFR4rpzUKq6nGrx3NzsjOE6RgwxGpfrSzxy7XJaamCLU4 cKra1DSpG8GFVPnxcIuK8yBXF6OG4IuYh9XditWd0i9eLs+PM4Hw+wMdbnKYLvAZ DOChJiv+tRmTFj4WmOuvf97nM+M1QTprY6Q== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id jBI20kRw0usP for ; Mon, 2 May 2022 05:54:57 -0700 (PDT) Received: from [10.225.81.200] (hq6rw33.ad.shared [10.225.81.200]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4KsNNJ5Mpmz1Rvlc; Mon, 2 May 2022 05:54:56 -0700 (PDT) Message-ID: <46e95412-9a79-51f8-3d52-caed4875d41f@opensource.wdc.com> Date: Mon, 2 May 2022 21:54:55 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v4 00/10] Add Copy offload support Content-Language: en-US To: Dave Chinner , Nitesh Shetty Cc: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, dm-devel@redhat.com, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, nitheshshetty@gmail.com, linux-kernel@vger.kernel.org References: <20220426101241.30100-1-nj.shetty@samsung.com> <6a85e8c8-d9d1-f192-f10d-09052703c99a@opensource.wdc.com> <20220427124951.GA9558@test-zns> <20220502040951.GC1360180@dread.disaster.area> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20220502040951.GC1360180@dread.disaster.area> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 2022/05/02 13:09, Dave Chinner wrote: > On Wed, Apr 27, 2022 at 06:19:51PM +0530, Nitesh Shetty wrote: >> O Wed, Apr 27, 2022 at 11:19:48AM +0900, Damien Le Moal wrote: >>> On 4/26/22 19:12, Nitesh Shetty wrote: >>>> The patch series covers the points discussed in November 2021 virtua= l call >>>> [LSF/MM/BFP TOPIC] Storage: Copy Offload[0]. >>>> We have covered the Initial agreed requirements in this patchset. >>>> Patchset borrows Mikulas's token based approach for 2 bdev >>>> implementation. >>>> >>>> Overall series supports =E2=80=93 >>>> >>>> 1. Driver >>>> - NVMe Copy command (single NS), including support in nvme-target (f= or >>>> block and file backend) >>> >>> It would also be nice to have copy offload emulation in null_blk for = testing. >>> >> >> We can plan this in next phase of copy support, once this series settl= es down. >=20 > Why not just hook the loopback driver up to copy_file_range() so > that the backend filesystem can just reflink copy the ranges being > passed? That would enable testing on btrfs, XFS and NFSv4.2 hosted > image files without needing any special block device setup at all... That is a very good idea ! But that will cover only the non-zoned case. F= or copy offload on zoned devices, adding support in null_blk is probably the simp= lest thing to do. >=20 > i.e. I think you're doing this compeltely backwards by trying to > target non-existent hardware first.... >=20 > Cheers, >=20 > Dave. --=20 Damien Le Moal Western Digital Research