From: Markus Elfring <Markus.Elfring@web.de>
To: "Andrew F. Davis" <afd@ti.com>,
Basharath Hussain Khaja <basharath@couthit.com>,
Parvathi Pudi <parvathi@couthit.com>,
Roger Quadros <rogerq@ti.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Andrew Lunn <andrew+netdev@lunn.ch>,
Conor Dooley <conor+dt@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Diogo Ivo <diogo.ivo@siemens.com>,
Eric Dumazet <edumazet@google.com>,
Guillaume La Roque <glaroque@baylibre.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Jakub Kicinski <kuba@kernel.org>,
Javier Carrasco <javier.carrasco.cruz@gmail.com>,
Kory Maincent <kory.maincent@bootlin.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
MD Danish Anwar <danishanwar@ti.com>,
Meghana Malladi <m-malladi@ti.com>,
Murali Karicheri <m-karicheri2@ti.com>,
Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Rob Herring <robh@kernel.org>,
Sai Krishna <saikrishnag@marvell.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Simon Horman <horms@kernel.org>, Suman Anna <s-anna@ti.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
krishna@couthit.com, mohan@couthit.com, pmohan@couthit.com,
prajith@ti.com, Praneeth Bajjuri <praneeth@ti.com>,
Pratheesh Gangadhar <pratheesh@ti.com>,
Sriramakrishnan <srk@ti.com>, Roger Quadros <rogerq@kernel.org>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: Re: [PATCH net-next v11 2/5] net: ti: prueth: Adds ICSSM Ethernet driver
Date: Tue, 22 Jul 2025 17:36:50 +0200 [thread overview]
Message-ID: <46fb997f-ba83-44af-aad3-c8406fc7cbea@web.de> (raw)
In-Reply-To: <20250722132700.2655208-3-parvathi@couthit.com>
…
> +++ b/drivers/net/ethernet/ti/icssm/icssm_prueth.c
> @@ -0,0 +1,609 @@
…
> +static int icssm_prueth_probe(struct platform_device *pdev)
> +{
…
> + /* register the network devices */
> + if (eth0_node) {
…
> + }
> +
> + if (eth1_node) {
…
> + }
> +
> + if (eth1_node)
> + of_node_put(eth1_node);
> + if (eth0_node)
> + of_node_put(eth0_node);
> + return 0;
…
I suggest to avoid duplicate condition checks for such a function implementation.
Can any code be reused from another function?
Regards,
Markus
next prev parent reply other threads:[~2025-07-22 16:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 13:25 [PATCH net-next v11 0/5] PRU-ICSSM Ethernet Driver Parvathi Pudi
2025-07-22 13:25 ` [PATCH net-next v11 1/5] dt-bindings: net: ti: Adds DUAL-EMAC mode support on PRU-ICSS2 for AM57xx, AM43xx and AM33xx SOCs Parvathi Pudi
2025-07-22 13:25 ` [PATCH net-next v11 2/5] net: ti: prueth: Adds ICSSM Ethernet driver Parvathi Pudi
2025-07-22 15:36 ` Markus Elfring [this message]
2025-07-23 1:47 ` Jakub Kicinski
2025-07-23 1:47 ` Jakub Kicinski
2025-07-23 11:03 ` Parvathi Pudi
2025-07-23 11:03 ` Parvathi Pudi
2025-07-22 13:25 ` [PATCH net-next v11 3/5] net: ti: prueth: Adds PRUETH HW and SW configuration Parvathi Pudi
2025-07-22 14:32 ` [PATCH net-next v11 4/5] net: ti: prueth: Adds link detection, RX and TX support Parvathi Pudi
2025-07-22 14:32 ` [PATCH net-next v11 5/5] net: ti: prueth: Adds IEP support for PRUETH on AM33x, AM43x and AM57x SOCs Parvathi Pudi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46fb997f-ba83-44af-aad3-c8406fc7cbea@web.de \
--to=markus.elfring@web.de \
--cc=afd@ti.com \
--cc=andrew+netdev@lunn.ch \
--cc=basharath@couthit.com \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=diogo.ivo@siemens.com \
--cc=edumazet@google.com \
--cc=glaroque@baylibre.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=krishna@couthit.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=m-malladi@ti.com \
--cc=mohan@couthit.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parvathi@couthit.com \
--cc=pmohan@couthit.com \
--cc=prajith@ti.com \
--cc=praneeth@ti.com \
--cc=pratheesh@ti.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=rogerq@ti.com \
--cc=s-anna@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=saikrishnag@marvell.com \
--cc=srk@ti.com \
--cc=ssantosh@kernel.org \
--cc=vadim.fedorenko@linux.dev \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.