From mboxrd@z Thu Jan 1 00:00:00 1970 From: matthieu castet Subject: Re: [Patch] reenable fifos if we get an error while fifos disabled Date: Sun, 30 Sep 2007 23:30:13 +0200 Message-ID: <47001565.2010607@free.fr> References: <46FFEF22.8080205@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <46FFEF22.8080205-S0/GAf8tV78@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org To: Stephan Schmid Cc: Nouveau List-Id: nouveau.vger.kernel.org Stephan Schmid wrote: > Hello, > while playing around with multiple fifo contexts I got fifo hangs when > opening glxgears nr.3. > The reason is that in drm/linux_core/nouveau_fifo.c l.342 > engine->graph.create_context() returns -ENOMEM (I dont know why but I > think this problems also appears with other errors). May be because of hash collision. I got similar failure, but I didn't take time to investigate. > But the real problem is that then nouveau_fifo alloc() returns without > reenabling fifo execution, so all fifos hang. With this patch glxgears > nr.3 only prints scary messages and falls back to software rendering. Great. May be using a goto to jump at the end, could avoid code duplication. Matthieu