From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Emelyanov Subject: Re: [PATCH 1/5] Add notification about some major slab events Date: Mon, 01 Oct 2007 16:57:18 +0400 Message-ID: <4700EEAE.1090208@openvz.org> References: <46F91841.9070708@openvz.org> <46F91898.5060400@openvz.org> <4700E03B.6000102@linux.vnet.ibm.com> <4700E477.2060607@openvz.org> <4700E8F2.7000206@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4700E8F2.7000206-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Cc: Linux Containers , Christoph Lameter List-Id: containers.vger.kernel.org Balbir Singh wrote: > Pavel Emelyanov wrote: >>> harsh, hard to review since the definition of the above function >>> is not known. >> What do you mean by "not known"? I is declared above :) >> > > I meant, we only know the stub weak functions. Does slub_*_notify > fail only on fatal errors? If not, then the failure might be It depends on the listener of the event when to fail. The slub notification mechanism is not the accounting at all it just sends notifications. > unfair. >