From: Brian Haley <brian.haley@hp.com>
To: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
Cc: brian.haley@hp.com, dlstevens@us.ibm.com, davem@davemloft.net,
netdev@vger.kernel.org
Subject: Re: [IPV6] Fix ICMPv6 redirect handling with target multicast address
Date: Mon, 01 Oct 2007 13:36:24 -0400 [thread overview]
Message-ID: <47013018.1020002@hp.com> (raw)
In-Reply-To: <20071001.204921.52365121.yoshfuji@linux-ipv6.org>
Hi,
YOSHIFUJI Hideaki / 吉藤英明 wrote:
>>> I think it'd also be better if you add the check to be:
>>>
>>> if (ipv6_addr_type(target) &
>>> (IPV6_ADDR_LINKLOCAL|IPV6_ADDR_UNICAST))
>>>
>>> or something along those lines, rather than reproducing ipv6_addr_type()
>>> code
>>> separately in a new ipv6_addr_linklocal() function.
>
> I'm fine with the idea of the fix itself.
Ok, in both the receive and send code?
> Please use ipv6_addr_type() so far and convert other users as well
> to ipv6_addr_linklocal() in another patch.
I'll re-do the patch.
-Brian
next prev parent reply other threads:[~2007-10-01 17:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-28 16:26 [IPV6] Fix ICMPv6 redirect handling with target multicast address Brian Haley
2007-09-29 0:50 ` David Stevens
2007-09-29 1:04 ` YOSHIFUJI Hideaki / 吉藤英明
2007-10-01 3:27 ` Brian Haley
2007-10-01 11:49 ` YOSHIFUJI Hideaki / 吉藤英明
2007-10-01 17:36 ` Brian Haley [this message]
2007-10-02 19:18 ` [IPv6] " Brian Haley
2007-10-02 20:39 ` David Stevens
2007-10-02 21:06 ` Brian Haley
2007-10-02 22:41 ` David Stevens
2007-10-03 14:44 ` [IPv6] Fix ICMPv6 redirect handling with target multicast address, try 3 Brian Haley
2007-10-08 7:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47013018.1020002@hp.com \
--to=brian.haley@hp.com \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.