From: Alexey Starikovskiy <aystarik@gmail.com>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Alexey Starikovskiy <astarikovskiy@suse.de>,
Linux-acpi@vger.kernel.org, Len Brown <lenb@kernel.org>
Subject: Re: [PATCH 2/2] ACPICA: hw: Don't carry spinlock over suspend
Date: Tue, 02 Oct 2007 00:27:43 +0400 [thread overview]
Message-ID: <4701583F.9060507@gmail.com> (raw)
In-Reply-To: <200710012238.09274.rjw@sisk.pl>
Rafael J. Wysocki wrote:
> On Sunday, 30 September 2007 20:39, Alexey Starikovskiy wrote:
>> ACPI uses acpi_get_register() in order to get into suspend.
>> This function is guarded by acpi_gbl_hardware_lock, which will be carried
>> into resume phase.
>> At resume interrupts are enabled and first ACPI interrupt deadlocks on this
>> lock.
>
> Ouch. That might have bitten quite some people, I guess.
>
>> Solution seems to be to not lock register read, as there are no concurrent
>> activity at this point.
>>
>> Reference: http://bugzilla.kernel.org/show_bug.cgi?id=7499
>>
>> Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
>
> Do you think it's -stable material?
Seem to be trivial.
Regards,
Alex.
next prev parent reply other threads:[~2007-10-01 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070930183936.32654.44391.stgit@samsung>
[not found] ` <20070930183942.32654.16220.stgit@samsung>
2007-10-01 20:38 ` [PATCH 2/2] ACPICA: hw: Don't carry spinlock over suspend Rafael J. Wysocki
2007-10-01 20:27 ` Alexey Starikovskiy [this message]
2007-10-02 4:07 Andrey Borzenkov
2007-10-02 15:59 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4701583F.9060507@gmail.com \
--to=aystarik@gmail.com \
--cc=Linux-acpi@vger.kernel.org \
--cc=astarikovskiy@suse.de \
--cc=lenb@kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.