From: Corey Hickey <bugfood-ml@fatooh.org>
To: Patrick McHardy <kaber@trash.net>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH 05/10] Add divisor.
Date: Mon, 01 Oct 2007 13:47:04 -0700 [thread overview]
Message-ID: <47015CC8.2080507@fatooh.org> (raw)
In-Reply-To: <4700F83F.9020300@trash.net>
Patrick McHardy wrote:
> Corey Hickey wrote:
>> Make hash divisor user-configurable.
>>
>
>> @@ -120,7 +121,7 @@ static __inline__ unsigned sfq_fold_hash(struct sfq_sched_data *q, u32 h, u32 h1
>> /* Have we any rotation primitives? If not, WHY? */
>> h ^= (h1<<pert) ^ (h1>>(0x1F - pert));
>> h ^= h>>10;
>> - return h & 0x3FF;
>> + return h & (q->hash_divisor-1);
>
>
> This assumes that hash_divisor is a power of two, but this is
> not enforced anywhere.
Ok. I'll move that part from userspace to the kernel. That should be
better anyway.
-Corey
next prev parent reply other threads:[~2007-10-01 20:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-28 22:52 SFQ: backport some features from ESFQ (try 4) Corey Hickey
2007-09-28 22:52 ` [PATCH 01/10] Preparatory refactoring part 1 Corey Hickey
2007-10-01 13:25 ` Patrick McHardy
2007-10-01 20:46 ` Corey Hickey
2007-10-02 3:17 ` Patrick McHardy
2007-09-28 22:52 ` [PATCH 02/10] Preparatory refactoring part 2 Corey Hickey
2007-10-01 13:33 ` Patrick McHardy
2007-10-01 20:46 ` Corey Hickey
2007-10-02 3:19 ` Patrick McHardy
2007-09-28 22:52 ` [PATCH 03/10] Move two functions Corey Hickey
2007-10-01 13:27 ` Patrick McHardy
2007-10-01 20:46 ` Corey Hickey
2007-09-28 22:52 ` [PATCH 04/10] Make "depth" (number of queues) user-configurable: Corey Hickey
2007-09-28 22:52 ` [PATCH 05/10] Add divisor Corey Hickey
2007-10-01 13:38 ` Patrick McHardy
2007-10-01 20:47 ` Corey Hickey [this message]
2007-09-28 22:52 ` [PATCH 06/10] Make qdisc changeable Corey Hickey
2007-10-01 13:43 ` Patrick McHardy
2007-10-01 20:47 ` Corey Hickey
2007-09-28 22:52 ` [PATCH 07/10] Remove comments about hardcoded values Corey Hickey
2007-09-28 22:52 ` [PATCH 08/10] Multiply perturb_period by HZ when used rather than when assigned Corey Hickey
2007-09-28 22:52 ` [PATCH 09/10] Change perturb_period to unsigned Corey Hickey
2007-10-01 13:45 ` Patrick McHardy
2007-10-01 20:47 ` Corey Hickey
2007-09-28 22:52 ` [PATCH 10/10] Use nested compat attributes to pass parameters Corey Hickey
2007-10-01 13:54 ` Patrick McHardy
2007-10-01 20:47 ` Corey Hickey
2007-10-02 3:21 ` Patrick McHardy
2007-09-28 22:54 ` sfq Corey Hickey
2007-09-28 22:57 ` sfq (iproute2 patches) Corey Hickey
2007-09-28 22:54 ` [PATCH 1/3] SFQ: Support changing depth and divisor Corey Hickey
2007-09-28 22:54 ` [PATCH 2/3] Change perturb_period to unsigned Corey Hickey
2007-09-28 22:54 ` [PATCH 3/3] Use nested compat attributes for passing parameters to the kernel Corey Hickey
2007-09-29 15:38 ` SFQ: backport some features from ESFQ (try 4) Patrick McHardy
2007-09-29 17:36 ` Corey Hickey
-- strict thread matches above, loose matches on Subject: below --
2007-08-25 22:26 [PATCH 00/10] SFQ: backport some features from ESFQ (try 3) Corey Hickey
2007-08-25 22:26 ` [PATCH 05/10] Add divisor Corey Hickey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47015CC8.2080507@fatooh.org \
--to=bugfood-ml@fatooh.org \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.