All of lore.kernel.org
 help / color / mirror / Atom feed
From: INAKOSHI Hiroya <inakoshi.hiroya@jp.fujitsu.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] SIGTERM and SIGINT handler to flush xentop -b	outputs
Date: Tue, 02 Oct 2007 20:10:49 +0900	[thread overview]
Message-ID: <47022739.6070109@jp.fujitsu.com> (raw)

 Flush stdout when xentop -b gets SIGINT and SIGTERM.  It is useful when
you stop xentop -b by keyboard interrupt or by other programs such as
killall from a batch script.  You would have missed the bottom part of
xentop outputs without this patch.
 This second patch calls no unsafe function in a signal handler.  The
main loop breaks and xentop exits normally when a flag is set by the
signal handler.  Stdout is flushed accordingly.

Signed-off-by: INAKOSHI Hiroya <inakoshi.hiroya@jp.fujitsu.com>


diff -r 83239b289072 tools/xenstat/xentop/xentop.c
--- a/tools/xenstat/xentop/xentop.c	Thu Sep 27 16:29:43 2007 -0600
+++ b/tools/xenstat/xentop/xentop.c	Tue Oct 02 16:53:10 2007 +0900
@@ -28,6 +28,7 @@
 #include <sys/time.h>
 #include <time.h>
 #include <unistd.h>
+#include <signal.h>
 #if defined(__linux__)
 #include <linux/kdev_t.h>
 #endif
@@ -1011,6 +1012,12 @@ static void top(void)
 	free(domains);
 }

+static volatile int sigout_flag = 0;
+
+void a_sig_handler(int sig) {
+	sigout_flag = 1;
+}
+
 int main(int argc, char **argv)
 {
 	int opt, optind = 0;
@@ -1102,6 +1109,14 @@ int main(int argc, char **argv)
 			ch = getch();
 		} while (handle_key(ch));
 	} else {
+			struct sigaction sa = {
+				.sa_handler = a_sig_handler,
+				.sa_flags = 0
+			};
+			sigemptyset(&sa.sa_mask);
+			sigaction(SIGINT, &sa, NULL);
+			sigaction(SIGTERM, &sa, NULL);
+
 			do {
 				gettimeofday(&curtime, NULL);
 				top();
@@ -1109,7 +1124,7 @@ int main(int argc, char **argv)
 				if ((!loop) && !(--iterations))
 					break;
 				sleep(delay);
-			} while (1);
+			} while (sigout_flag == 0);
 	}

 	/* Cleanup occurs in cleanup(), so no work to do here. */

             reply	other threads:[~2007-10-02 11:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-02 11:10 INAKOSHI Hiroya [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-10-02  1:22 [PATCH] SIGTERM and SIGINT handler to flush xentop -b outputs INAKOSHI Hiroya
2007-10-02  1:29 ` John Levon
2007-10-02 10:57   ` INAKOSHI Hiroya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47022739.6070109@jp.fujitsu.com \
    --to=inakoshi.hiroya@jp.fujitsu.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.