From: Daniel Drake <dsd@gentoo.org>
To: John Linville <linville@tuxdriver.com>
Cc: Michael Buesch <mb@bu3sch.de>,
Ulrich Kunitz <kune@deine-taler.de>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] z1211: Make the LEDs warning debug-only
Date: Tue, 02 Oct 2007 17:34:38 +0100 [thread overview]
Message-ID: <4702731E.5070502@gentoo.org> (raw)
In-Reply-To: <200709291223.20926.mb@bu3sch.de>
Michael Buesch wrote:
> This warning triggers now and then with an -ETIMEDOUT error.
> Though the LEDs work fine.
> Make this warning debug-only, as nobody is really interested
> in a LED failure that happens only now and then.
> If the LEDs don't work, one can easily enable debugging to see
> what's going on.
> This reduces dmesg spamming.
>
> Signed-off-by: Michael Buesch <mb@bu3sch.de>
Acked-by: Daniel Drake <dsd@gentoo.org>
>
> Index: wireless-2.6/drivers/net/wireless/z1211/zd_mac.c
> ===================================================================
> --- wireless-2.6.orig/drivers/net/wireless/z1211/zd_mac.c 2007-09-25 22:51:28.000000000 +0200
> +++ wireless-2.6/drivers/net/wireless/z1211/zd_mac.c 2007-09-29 12:19:54.000000000 +0200
> @@ -922,7 +922,7 @@ static void link_led_handler(struct work
> r = zd_chip_control_leds(chip,
> is_associated ? LED_ASSOCIATED : LED_SCANNING);
> if (r)
> - dev_err(zd_mac_dev(mac), "zd_chip_control_leds error %d\n", r);
> + dev_dbg_f(zd_mac_dev(mac), "zd_chip_control_leds error %d\n", r);
>
> queue_delayed_work(zd_workqueue, &mac->housekeeping.link_led_work,
> LINK_LED_WORK_DELAY);
>
prev parent reply other threads:[~2007-10-02 16:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-29 10:23 [PATCH] z1211: Make the LEDs warning debug-only Michael Buesch
2007-10-02 16:34 ` Daniel Drake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4702731E.5070502@gentoo.org \
--to=dsd@gentoo.org \
--cc=kune@deine-taler.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.