From mboxrd@z Thu Jan 1 00:00:00 1970 From: Balbir Singh Subject: Re: [PATCH 0/3] Consolidate cgroup files creation for resource counters Date: Wed, 03 Oct 2007 23:29:02 +0530 Message-ID: <4703D866.10305@linux.vnet.ibm.com> References: <470374A7.6030805@openvz.org> Reply-To: balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <470374A7.6030805-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Pavel Emelyanov Cc: Linux Containers , Paul Menage List-Id: containers.vger.kernel.org Pavel Emelyanov wrote: > Right now we have only one controller in -mm tree - the memory > one - and it initializes all its files manually. After I developed > the kernel memory one it turned out, that the names of resource > counter specific files has changed. In the future, if anything in > the resource counters change, we'll have to rewrite all the > controllers we will have by that time. > > To make all the containers working with the resource counters > look similar I propose to create the resource counters specific > files in one place. > > Any comments/wishes before I send it to Andrew are welcome. > > Signed-off-by: Pavel Emelyanov For memory your changes make sense, but the file names cannot be limit_in_bytes and usage_in_bytes for other controllers (if and when they use res_counters) -- Warm Regards, Balbir Singh Linux Technology Center IBM, ISTL