From: Jeff Garzik <jeff@garzik.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: ralf@linux-mips.org, davem@davemloft.net, netdev@vger.kernel.org,
pidoux@ccr.jussieu.fr
Subject: Re: [PATCH] Fix rose.ko oops on unload
Date: Wed, 03 Oct 2007 15:04:20 -0400 [thread overview]
Message-ID: <4703E7B4.2090309@garzik.org> (raw)
In-Reply-To: <20071003185413.GA16242@martell.zuzino.mipt.ru>
Alexey Dobriyan wrote:
> Quick'n'dirty fix to 100% oops on "rmmod rose". Do you want me to
> properly unwind everything before .24?
> -----------
> Commit a3d384029aa304f8f3f5355d35f0ae274454f7cd aka
> "[AX.25]: Fix unchecked rose_add_loopback_neigh uses"
> transformed rose_loopback_neigh var into statically allocated one.
> However, on unload it will be kfree's which can't work.
I'm definitely missing something... assuming your patch is applied,
where is the kfree() for rose_loopback_neigh ?
Jeff
next prev parent reply other threads:[~2007-10-03 19:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 18:54 [PATCH] Fix rose.ko oops on unload Alexey Dobriyan
2007-10-03 19:04 ` Jeff Garzik [this message]
2007-10-03 19:21 ` Alexey Dobriyan
2007-10-08 6:44 ` David Miller
2007-12-14 21:58 ` [PATCH] [ROSE] reverts commits d85838c55d836c33077344fab424f200f2827d84 Bernard Pidoux
2007-11-21 22:13 ` Inconsistent lock state and possible irq lock inversion dependency detected in ax25.ko Bernard Pidoux
2007-11-28 13:48 ` Jarek Poplawski
2007-12-02 17:37 ` Bernard Pidoux
2007-12-02 22:02 ` Jarek Poplawski
2007-12-04 22:26 ` Bernard Pidoux
2007-12-04 23:17 ` Jarek Poplawski
2007-12-05 0:45 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4703E7B4.2090309@garzik.org \
--to=jeff@garzik.org \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=pidoux@ccr.jussieu.fr \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.