From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org, Alan <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org, htejun@gmail.com
Subject: Re: [patch 01/10] pata_acpi: restore driver
Date: Wed, 03 Oct 2007 16:29:58 -0400 [thread overview]
Message-ID: <4703FBC6.80104@garzik.org> (raw)
In-Reply-To: <200710022052.l92Kqx0w021673@imap1.linux-foundation.org>
akpm@linux-foundation.org wrote:
> From: Alan Cox <alan@redhat.com>
>
> This patch assumes the mode filter patches were applied, if not then ping
> me and I'll send the trivially different patch (extra argument to
> mode_filter)
>
> Don't assume the BIOS can validate modes or has any sense at all. Instead use
> the BIOS timings to deduce the modes.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
> Cc: Tejun Heo <htejun@gmail.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/ata/Kconfig | 9
> drivers/ata/Makefile | 2
> drivers/ata/pata_acpi.c | 403 ++++++++++++++++++++++++++++++++++++++
> 3 files changed, 414 insertions(+)
Can I get a better email subject and patch description please?
Just reply to this email, and I can hand-edit the patch from there.
"pata_acpi: restore driver" is a bad one-line summary, because nothing
was lost (hence nothing to be restored). it's simply a new driver.
The patch description is also wanting -- it describes work-in-progress,
but should really be a summary of what the pata_acpi driver is, why we
want it, and how it works.
Email some text, and I shall apply straightaway.
Jeff
next prev parent reply other threads:[~2007-10-03 20:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 20:52 [patch 01/10] pata_acpi: restore driver akpm
2007-10-03 20:29 ` Jeff Garzik [this message]
2007-10-03 20:54 ` Alan Cox
2007-10-03 21:05 ` James Bottomley
2007-10-03 21:16 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4703FBC6.80104@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.