From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Emelyanov Subject: Re: [PATCH 2/3] Introduce the res_counter_populate() function Date: Thu, 04 Oct 2007 10:40:23 +0400 Message-ID: <47048AD7.3040406@openvz.org> References: <470374A7.6030805@openvz.org> <470375B2.5090100@openvz.org> <6599ad830710030902h71737aban4e7cf4e4d1e4d4d1@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <6599ad830710030902h71737aban4e7cf4e4d1e4d4d1-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Paul Menage , Balbir Singh Cc: Linux Containers List-Id: containers.vger.kernel.org Paul Menage wrote: > On 10/3/07, Pavel Emelyanov wrote: >> + >> + strcpy(files[RES_USAGE].name, "usage_in_bytes"); > > This prevents the resource counters from being used for anything that > doesn't measure its limit/usage in bytes. E.g. number of tasks. > > I like the idea of having a unified interface, but can't they just be > called "usage" and "limit"? I see. OK, I will rework the patches to make them more generic. Moreover, I've just faced one more race in this set :( > Paul > Thanks, Pavel