From: Andrei Konovalov <akonovalov@ru.mvista.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linux-kernel@vger.kernel.org,
linux-fbdev-devel@lists.sourceforge.net, linuxppc@ozlabs.org,
adaplas@gmail.com
Subject: Re: [PATCH 2/6] Xilinxfb: Replace calls to printk with dev_dbg, dev_err, etc.
Date: Thu, 04 Oct 2007 16:06:15 +0400 [thread overview]
Message-ID: <4704D737.4010003@ru.mvista.com> (raw)
In-Reply-To: <20071001155738.6114.51384.stgit@trillian.cg.shawcable.net>
Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
> The dev_dbg, dev_err, etc functions provide more context that plain
> vanilla printk which is useful for debugging. Where appropriate,
> change printk calls to the appropriate dev_*() call.
>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
Acked-by: Andrei Konovalov <akonovalov@ru.mvista.com>
> drivers/video/xilinxfb.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
next prev parent reply other threads:[~2007-10-04 12:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 15:57 [PATCH 0/6] Patch series to add of_platform binding to xilinxfb Grant Likely
2007-10-01 15:57 ` Grant Likely
2007-10-01 15:57 ` [PATCH 1/6] Xilinxfb: add banner output to probe routine when DEBUG is defined Grant Likely
2007-10-04 12:05 ` Andrei Konovalov
2007-10-01 15:57 ` [PATCH 2/6] Xilinxfb: Replace calls to printk with dev_dbg, dev_err, etc Grant Likely
2007-10-04 12:06 ` Andrei Konovalov [this message]
2007-10-01 15:57 ` [PATCH 3/6] Xilinxfb: rename failout labels to reflect failure Grant Likely
2007-10-01 15:57 ` Grant Likely
2007-10-04 12:06 ` Andrei Konovalov
2007-10-01 15:57 ` [PATCH 4/6] xilinxfb: Split device setup from bus binding Grant Likely
2007-10-01 15:57 ` Grant Likely
2007-10-04 12:07 ` Andrei Konovalov
2007-10-01 15:57 ` [PATCH 5/6] Xilinxfb: cleanup platform_bus binding to use platform bus API Grant Likely
2007-10-01 15:57 ` Grant Likely
2007-10-04 12:07 ` Andrei Konovalov
2007-10-01 15:57 ` [PATCH 6/6] Xilinxfb: add of_platform bus binding Grant Likely
2007-10-01 15:57 ` Grant Likely
2007-10-01 16:42 ` Akinobu Mita
2007-10-01 16:46 ` Grant Likely
2007-10-01 16:46 ` Grant Likely
2007-10-04 12:11 ` Andrei Konovalov
2007-10-03 0:15 ` [PATCH 0/6] Patch series to add of_platform binding to xilinxfb Antonino A. Daplas
2007-10-03 0:15 ` [Linux-fbdev-devel] " Antonino A. Daplas
2007-10-09 4:43 ` Grant Likely
2007-10-09 4:43 ` [Linux-fbdev-devel] " Grant Likely
2007-10-09 5:04 ` Antonino A. Daplas
2007-10-09 5:04 ` [Linux-fbdev-devel] " Antonino A. Daplas
2007-10-09 17:39 ` Grant Likely
2007-10-09 17:39 ` [Linux-fbdev-devel] " Grant Likely
2007-10-09 17:39 ` Grant Likely
2007-10-09 21:06 ` Antonino A. Daplas
2007-10-09 21:06 ` [Linux-fbdev-devel] " Antonino A. Daplas
2007-10-09 21:06 ` Antonino A. Daplas
[not found] ` <4703C8A7.8070001@ru.mvista.com>
2007-10-03 18:22 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4704D737.4010003@ru.mvista.com \
--to=akonovalov@ru.mvista.com \
--cc=adaplas@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.